[GitHub] [flink] snuyanzin commented on pull request #18601: [FLINK-25699][table] Use HashMap for MAP value constructors

2022-06-07 Thread GitBox


snuyanzin commented on PR #18601:
URL: https://github.com/apache/flink/pull/18601#issuecomment-1149427631

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [flink] snuyanzin commented on pull request #18601: [FLINK-25699][table] Use HashMap for MAP value constructors

2022-06-02 Thread GitBox


snuyanzin commented on PR #18601:
URL: https://github.com/apache/flink/pull/18601#issuecomment-1144786922

   @MartijnVisser , @twalthr sorry for the poke.
   Since the PR has been already approved, could you please help with merging 
this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [flink] snuyanzin commented on pull request #18601: [FLINK-25699][table] Use HashMap for MAP value constructors

2022-04-20 Thread GitBox


snuyanzin commented on PR #18601:
URL: https://github.com/apache/flink/pull/18601#issuecomment-1103769890

   rebased and resolved conflicts
   
   @twalthr sorry for the poke
   since this PR this PR is approved by @slinkydeveloper and you are one of the 
committers dealing with `table` module, could you please have a look once you 
have time?
   thank you


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [flink] snuyanzin commented on pull request #18601: [FLINK-25699][table] Use HashMap for MAP value constructors

2022-03-23 Thread GitBox


snuyanzin commented on pull request #18601:
URL: https://github.com/apache/flink/pull/18601#issuecomment-1076021310


   @slinkydeveloper thank you for your feedback
   I rebased the PR so that the conflicts are resolved now.
   Once you have time please let me know if anything is still missing or if 
need to squash commits


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] snuyanzin commented on pull request #18601: [FLINK-25699][table] Use HashMap for MAP value constructors

2022-03-22 Thread GitBox


snuyanzin commented on pull request #18601:
URL: https://github.com/apache/flink/pull/18601#issuecomment-1075521548


   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] snuyanzin commented on pull request #18601: [FLINK-25699][table] Use HashMap for MAP value constructors

2022-03-21 Thread GitBox


snuyanzin commented on pull request #18601:
URL: https://github.com/apache/flink/pull/18601#issuecomment-1073901631


   @flinkbot run azure
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] snuyanzin commented on pull request #18601: [FLINK-25699][table] Use HashMap for MAP value constructors

2022-03-18 Thread GitBox


snuyanzin commented on pull request #18601:
URL: https://github.com/apache/flink/pull/18601#issuecomment-1072292740


   @slinkydeveloper , @twalthr sorry for the poke...
   could you please have a look once you have time?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] snuyanzin commented on pull request #18601: [FLINK-25699][table] Use HashMap for MAP value constructors

2022-03-18 Thread GitBox


snuyanzin commented on pull request #18601:
URL: https://github.com/apache/flink/pull/18601#issuecomment-1072292740


   @slinkydeveloper , @twalthr sorry for the poke...
   could you please have a look once you have time?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org