[GitHub] [flink] suez1224 commented on a change in pull request #7978: [FLINK-11910] [Yarn] add customizable yarn application type

[GitBox]

suez1224 commented on a change in pull request #7978: [FLINK-11910] [Yarn] add 
customizable yarn application type
URL: https://github.com/apache/flink/pull/7978#discussion_r272401341
 
 

 ##
 File path: 
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
 ##
 @@ -988,7 +992,7 @@ public ApplicationReport startAppMaster(
final String customApplicationName = customName != null ? 
customName : applicationName;
 
appContext.setApplicationName(customApplicationName);
-   appContext.setApplicationType("Apache Flink");
+   appContext.setApplicationType(applicationType.isEmpty() ? 
"Apache Flink" : applicationType);
 
 Review comment:
   Can't we just do the following?
 
appContext.setApplicationType(dynProperties.getOrDefault("application-type",  
"Apache Flink"));


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] suez1224 commented on a change in pull request #7978: [FLINK-11910] [Yarn] add customizable yarn application type

[GitBox]

suez1224 commented on a change in pull request #7978: [FLINK-11910] [Yarn] add 
customizable yarn application type
URL: https://github.com/apache/flink/pull/7978#discussion_r272401356
 
 

 ##
 File path: 
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
 ##
 @@ -138,6 +138,8 @@
private String zookeeperNamespace;
 
private String nodeLabel;
+   /* This field can be override by dynamic property application-type */
+   private String applicationType;
 
 Review comment:
   We don't need this instance variable. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] suez1224 commented on a change in pull request #7978: [FLINK-11910] [Yarn] add customizable yarn application type

[GitBox]

suez1224 commented on a change in pull request #7978: [FLINK-11910] [Yarn] add 
customizable yarn application type
URL: https://github.com/apache/flink/pull/7978#discussion_r272401378
 
 

 ##
 File path: 
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
 ##
 @@ -468,6 +470,8 @@ private void 
validateClusterSpecification(ClusterSpecification clusterSpecificat
flinkConfiguration.setString(dynProperty.getKey(), 
dynProperty.getValue());
}
 
+   this.applicationType = 
dynProperties.getOrDefault("application-type", "");
 
 Review comment:
   We dont need this line as well..


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services