[GitHub] [flink] sunjincheng121 commented on issue #8230: [FLINK-10977][table] Add streaming non-window FlatAggregate to Table API

2019-05-04 Thread GitBox 
sunjincheng121 commented on issue #8230: [FLINK-10977][table] Add streaming 
non-window FlatAggregate to Table API
URL: https://github.com/apache/flink/pull/8230#issuecomment-489392533
 
 
   Thanks for create the JIRA @hequn8128!
   +1 to merged.
   @flinkbot approve all


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] sunjincheng121 commented on issue #8230: [FLINK-10977][table] Add streaming non-window FlatAggregate to Table API

2019-05-04 Thread GitBox 
sunjincheng121 commented on issue #8230: [FLINK-10977][table] Add streaming 
non-window FlatAggregate to Table API
URL: https://github.com/apache/flink/pull/8230#issuecomment-489378092
 
 
   Thanks for your update!
   Then changes look good to me now!
   
   And one more thing is in current PR without the implementation of 
incremental mode, can you create a JIRA for incremental mode?
   
   Best,Jincheng


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] sunjincheng121 commented on issue #8230: [FLINK-10977][table] Add streaming non-window FlatAggregate to Table API

2019-04-21 Thread GitBox 
sunjincheng121 commented on issue #8230: [FLINK-10977][table] Add streaming 
non-window FlatAggregate to Table API
URL: https://github.com/apache/flink/pull/8230#issuecomment-485309539
 
 
   Thanks for your great work! 
   @flinkbot approve-until architecture
   @flinkbot attention @aljoscha @twalthr 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services