[GitHub] [flink] tillrohrmann commented on a change in pull request #10886: [FLINK-15623][checkstyle] Exclude target directory

2020-01-30 Thread GitBox
tillrohrmann commented on a change in pull request #10886: 
[FLINK-15623][checkstyle] Exclude target directory
URL: https://github.com/apache/flink/pull/10886#discussion_r373076627
 
 

 ##
 File path: tools/maven/suppressions.xml
 ##
 @@ -32,13 +32,6 @@ under the License.


 
-   
-   
-   
 
 Review comment:
   Thanks for the clarification.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] tillrohrmann commented on a change in pull request #10886: [FLINK-15623][checkstyle] Exclude target directory

2020-01-29 Thread GitBox
tillrohrmann commented on a change in pull request #10886: 
[FLINK-15623][checkstyle] Exclude target directory
URL: https://github.com/apache/flink/pull/10886#discussion_r372513419
 
 

 ##
 File path: tools/maven/suppressions.xml
 ##
 @@ -32,13 +32,6 @@ under the License.


 
-   
-   
-   
 
 Review comment:
   Is it because these files are only in the `target` directory?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] tillrohrmann commented on a change in pull request #10886: [FLINK-15623][checkstyle] Exclude target directory

2020-01-29 Thread GitBox
tillrohrmann commented on a change in pull request #10886: 
[FLINK-15623][checkstyle] Exclude target directory
URL: https://github.com/apache/flink/pull/10886#discussion_r372513221
 
 

 ##
 File path: tools/maven/suppressions.xml
 ##
 @@ -32,13 +32,6 @@ under the License.


 
-   
-   
-   
 
 Review comment:
   Why can we remove these suppressions? According to the comment, the Java 
Python files follow python naming conventions? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services