[GitHub] [flink] tillrohrmann commented on issue #9775: [FLINK-14186][e2e] Let JVM ignores unrecoginzed options to avoid end to end test failure in es 2.3.5 with JDK11

2019-09-26 Thread GitBox
tillrohrmann commented on issue #9775: [FLINK-14186][e2e] Let JVM ignores 
unrecoginzed options to avoid end to end test failure in es 2.3.5 with JDK11
URL: https://github.com/apache/flink/pull/9775#issuecomment-535485689
 
 
   I think we do not have to cover this scenario atm. Testing all different 
Java versions times the number of external systems easily leads to a 
combinatorial explosion. The existing test also does not test this scenario 
since it runs ES with Java 11 anyway.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] tillrohrmann commented on issue #9775: [FLINK-14186][e2e] Let JVM ignores unrecoginzed options to avoid end to end test failure in es 2.3.5 with JDK11

2019-09-26 Thread GitBox
tillrohrmann commented on issue #9775: [FLINK-14186][e2e] Let JVM ignores 
unrecoginzed options to avoid end to end test failure in es 2.3.5 with JDK11
URL: https://github.com/apache/flink/pull/9775#issuecomment-535438266
 
 
   We could use `if [[ ${PROFILE} != *"jdk11"* ]]; then` to filter out those 
tests.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] tillrohrmann commented on issue #9775: [FLINK-14186][e2e] Let JVM ignores unrecoginzed options to avoid end to end test failure in es 2.3.5 with JDK11

2019-09-26 Thread GitBox
tillrohrmann commented on issue #9775: [FLINK-14186][e2e] Let JVM ignores 
unrecoginzed options to avoid end to end test failure in es 2.3.5 with JDK11
URL: https://github.com/apache/flink/pull/9775#issuecomment-53534
 
 
   > One more question. Is `JAVA_OPTS="-XX:+IgnoreUnrecognizedVMOptions"` a 
common pattern during we migrate to 10 or later? I am thinking of make it a 
high level option that could be referred to.
   
   I would treat this as a separate issue.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services