[GitHub] [flink] twalthr commented on pull request #12263: [FLINK-16998][core] Support backwards compatibility for upgraded RowSerializer

2020-05-20 Thread GitBox


twalthr commented on pull request #12263:
URL: https://github.com/apache/flink/pull/12263#issuecomment-631688716


   Merged.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] twalthr commented on pull request #12263: [FLINK-16998][core] Support backwards compatibility for upgraded RowSerializer

2020-05-20 Thread GitBox


twalthr commented on pull request #12263:
URL: https://github.com/apache/flink/pull/12263#issuecomment-631460366


   Thanks @tzulitai. I addressed the remaining comments and will merge this 
once the build gives green light.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] twalthr commented on pull request #12263: [FLINK-16998][core] Support backwards compatibility for upgraded RowSerializer

2020-05-20 Thread GitBox


twalthr commented on pull request #12263:
URL: https://github.com/apache/flink/pull/12263#issuecomment-631385082


   Thanks for the feedback @tzulitai. After some offline discussion, the tests 
were partially incorrect. I hope the PR is in a better shape now.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org