[GitHub] [flink] tweise commented on pull request #19514: [FLINK-27308][Filesystem][S3] Update the Hadoop implementation for filesystems to 3.3.2
tweise commented on PR #19514: URL: https://github.com/apache/flink/pull/19514#issuecomment-1110177935 @MartijnVisser generally changes that modify dependencies are hard to back port as these can modify the final application in ways that we cannot adequately predict. This case here may be a bit different due to the self contained nature of the plugins and so I would not be opposed to bring it back to 1.15.x at least (I just saw that 1.15.0 is final). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] tweise commented on pull request #19514: [FLINK-27308][Filesystem][S3] Update the Hadoop implementation for filesystems to 3.3.2
tweise commented on PR #19514: URL: https://github.com/apache/flink/pull/19514#issuecomment-1109321314 > @tweise Are you referring to the ones like `org.apache.hadoop.thirdparty:hadoop-shaded-protobuf_3_7` and `org.apache.hadoop.thirdparty:hadoop-shaded-guava` ? > Yes, and the new/removed entries in general. Thanks for confirming that this is based on the dependency:tree output. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] tweise commented on pull request #19514: [FLINK-27308][Filesystem][S3] Update the Hadoop implementation for filesystems to 3.3.2
tweise commented on PR #19514: URL: https://github.com/apache/flink/pull/19514#issuecomment-1106834064 @MartijnVisser thanks for fixing the test. LGTM. From what I see it is the case, but would like to confirm nevertheless: All shaded dependencies are covered by the NOTICE changes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] tweise commented on pull request #19514: [FLINK-27308][Filesystem][S3] Update the Hadoop implementation for filesystems to 3.3.2
tweise commented on PR #19514: URL: https://github.com/apache/flink/pull/19514#issuecomment-1104477731 Please see https://github.com/apache/flink/pull/19540 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
