[GitHub] [flink] walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add two utils for Table transformations
walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add
two utils for Table transformations
URL: https://github.com/apache/flink/pull/9373#discussion_r362629986
##
File path:
flink-ml-parent/flink-ml-lib/src/test/java/org/apache/flink/ml/common/utils/DataStreamConversionUtilTest.java
##
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.ml.common.utils;
+
+import org.apache.flink.api.common.functions.MapFunction;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.ml.common.MLEnvironmentFactory;
+import org.apache.flink.streaming.api.datastream.DataStream;
+import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
+import org.apache.flink.table.api.Table;
+import org.apache.flink.table.api.TableSchema;
+import org.apache.flink.table.api.ValidationException;
+import org.apache.flink.types.Row;
+
+import org.junit.Assert;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.rules.ExpectedException;
+
+/**
+ * Unit Test for DataStreamConversionUtil.
+ */
+public class DataStreamConversionUtilTest {
+ @Rule
+ public ExpectedException thrown = ExpectedException.none();
+
+ @Test
+ public void test() throws Exception {
+ StreamExecutionEnvironment env =
MLEnvironmentFactory.getDefault().getStreamExecutionEnvironment();
+
+ DataStream input = env.fromElements(Row.of("a"));
+
+ Table table1 =
DataStreamConversionUtil.toTable(MLEnvironmentFactory.DEFAULT_ML_ENVIRONMENT_ID,
input, new String[]{"word"});
+ Assert.assertEquals(
+ new TableSchema(new String[]{"word"}, new
TypeInformation[]{TypeInformation.of(String.class)}),
+ table1.getSchema()
+ );
+
+ input = input.map(new GenericTypeMap());
+
+ Table table2 = DataStreamConversionUtil.toTable(
+ MLEnvironmentFactory.DEFAULT_ML_ENVIRONMENT_ID,
+ input,
+ new String[]{"word"},
+ new TypeInformation[]{TypeInformation.of(Integer.class)}
+ );
+
+ Assert.assertEquals(
+ new TableSchema(new String[]{"word"}, new
TypeInformation[]{TypeInformation.of(Integer.class)}),
+ table2.getSchema()
+ );
+
+ Table tableFromDataStreamWithTableSchema =
DataStreamConversionUtil.toTable(
+ MLEnvironmentFactory.DEFAULT_ML_ENVIRONMENT_ID,
+ input,
Review comment:
I am going ahead and assume this is right.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add two utils for Table transformations
walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add
two utils for Table transformations
URL: https://github.com/apache/flink/pull/9373#discussion_r362629866
##
File path:
flink-ml-parent/flink-ml-lib/src/test/java/org/apache/flink/ml/common/utils/DataStreamConversionUtilTest.java
##
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.ml.common.utils;
+
+import org.apache.flink.api.common.functions.MapFunction;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.ml.common.MLEnvironmentFactory;
+import org.apache.flink.streaming.api.datastream.DataStream;
+import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
+import org.apache.flink.table.api.Table;
+import org.apache.flink.table.api.TableSchema;
+import org.apache.flink.table.api.ValidationException;
+import org.apache.flink.types.Row;
+
+import org.junit.Assert;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.rules.ExpectedException;
+
+/**
+ * Unit Test for DataStreamConversionUtil.
+ */
+public class DataStreamConversionUtilTest {
+ @Rule
+ public ExpectedException thrown = ExpectedException.none();
+
+ @Test
+ public void test() throws Exception {
+ StreamExecutionEnvironment env =
MLEnvironmentFactory.getDefault().getStreamExecutionEnvironment();
+
+ DataStream input = env.fromElements(Row.of("a"));
+
+ Table table1 =
DataStreamConversionUtil.toTable(MLEnvironmentFactory.DEFAULT_ML_ENVIRONMENT_ID,
input, new String[]{"word"});
+ Assert.assertEquals(
+ new TableSchema(new String[]{"word"}, new
TypeInformation[]{TypeInformation.of(String.class)}),
+ table1.getSchema()
+ );
+
+ input = input.map(new GenericTypeMap());
+
+ Table table2 = DataStreamConversionUtil.toTable(
+ MLEnvironmentFactory.DEFAULT_ML_ENVIRONMENT_ID,
+ input,
+ new String[]{"word"},
+ new TypeInformation[]{TypeInformation.of(Integer.class)}
Review comment:
Got it. I am assuming this converts a "generic row" input datastream/set
into a typed table. which should not throw validation exception because we do
not know it is going to pass in the data `Row.of("a")` until runtime. is that
correct?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add two utils for Table transformations
walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add
two utils for Table transformations
URL: https://github.com/apache/flink/pull/9373#discussion_r362246055
##
File path:
flink-ml-parent/flink-ml-lib/src/test/java/org/apache/flink/ml/common/utils/DataStreamConversionUtilTest.java
##
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.ml.common.utils;
+
+import org.apache.flink.api.common.functions.MapFunction;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.ml.common.MLEnvironmentFactory;
+import org.apache.flink.streaming.api.datastream.DataStream;
+import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
+import org.apache.flink.table.api.Table;
+import org.apache.flink.table.api.TableSchema;
+import org.apache.flink.table.api.ValidationException;
+import org.apache.flink.types.Row;
+
+import org.junit.Assert;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.rules.ExpectedException;
+
+/**
+ * Unit Test for DataStreamConversionUtil.
+ */
+public class DataStreamConversionUtilTest {
+ @Rule
+ public ExpectedException thrown = ExpectedException.none();
+
+ @Test
+ public void test() throws Exception {
+ StreamExecutionEnvironment env =
MLEnvironmentFactory.getDefault().getStreamExecutionEnvironment();
+
+ DataStream input = env.fromElements(Row.of("a"));
+
+ Table table1 =
DataStreamConversionUtil.toTable(MLEnvironmentFactory.DEFAULT_ML_ENVIRONMENT_ID,
input, new String[]{"word"});
+ Assert.assertEquals(
+ new TableSchema(new String[]{"word"}, new
TypeInformation[]{TypeInformation.of(String.class)}),
+ table1.getSchema()
+ );
+
+ input = input.map(new GenericTypeMap());
Review comment:
is this conversion suppose to remove the "string" type within the content:
`Row.of("a")`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add two utils for Table transformations
walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add
two utils for Table transformations
URL: https://github.com/apache/flink/pull/9373#discussion_r362246483
##
File path:
flink-ml-parent/flink-ml-lib/src/test/java/org/apache/flink/ml/common/utils/DataStreamConversionUtilTest.java
##
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.ml.common.utils;
+
+import org.apache.flink.api.common.functions.MapFunction;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.ml.common.MLEnvironmentFactory;
+import org.apache.flink.streaming.api.datastream.DataStream;
+import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
+import org.apache.flink.table.api.Table;
+import org.apache.flink.table.api.TableSchema;
+import org.apache.flink.table.api.ValidationException;
+import org.apache.flink.types.Row;
+
+import org.junit.Assert;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.rules.ExpectedException;
+
+/**
+ * Unit Test for DataStreamConversionUtil.
+ */
+public class DataStreamConversionUtilTest {
+ @Rule
+ public ExpectedException thrown = ExpectedException.none();
+
+ @Test
+ public void test() throws Exception {
+ StreamExecutionEnvironment env =
MLEnvironmentFactory.getDefault().getStreamExecutionEnvironment();
+
+ DataStream input = env.fromElements(Row.of("a"));
+
+ Table table1 =
DataStreamConversionUtil.toTable(MLEnvironmentFactory.DEFAULT_ML_ENVIRONMENT_ID,
input, new String[]{"word"});
+ Assert.assertEquals(
+ new TableSchema(new String[]{"word"}, new
TypeInformation[]{TypeInformation.of(String.class)}),
+ table1.getSchema()
+ );
+
+ input = input.map(new GenericTypeMap());
+
+ Table table2 = DataStreamConversionUtil.toTable(
+ MLEnvironmentFactory.DEFAULT_ML_ENVIRONMENT_ID,
+ input,
+ new String[]{"word"},
+ new TypeInformation[]{TypeInformation.of(Integer.class)}
+ );
+
+ Assert.assertEquals(
+ new TableSchema(new String[]{"word"}, new
TypeInformation[]{TypeInformation.of(Integer.class)}),
+ table2.getSchema()
+ );
+
+ Table tableFromDataStreamWithTableSchema =
DataStreamConversionUtil.toTable(
+ MLEnvironmentFactory.DEFAULT_ML_ENVIRONMENT_ID,
+ input,
Review comment:
Assuming this is used for testing passing in a TableSchema instead of
colNames and colTypes. should we do another GenericTypeMap() conversion, like
this?
```suggestion
input.map(new GenericTypeMap()),
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add two utils for Table transformations
walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add
two utils for Table transformations
URL: https://github.com/apache/flink/pull/9373#discussion_r362246155
##
File path:
flink-ml-parent/flink-ml-lib/src/test/java/org/apache/flink/ml/common/utils/DataStreamConversionUtilTest.java
##
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.ml.common.utils;
+
+import org.apache.flink.api.common.functions.MapFunction;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.ml.common.MLEnvironmentFactory;
+import org.apache.flink.streaming.api.datastream.DataStream;
+import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
+import org.apache.flink.table.api.Table;
+import org.apache.flink.table.api.TableSchema;
+import org.apache.flink.table.api.ValidationException;
+import org.apache.flink.types.Row;
+
+import org.junit.Assert;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.rules.ExpectedException;
+
+/**
+ * Unit Test for DataStreamConversionUtil.
+ */
+public class DataStreamConversionUtilTest {
+ @Rule
+ public ExpectedException thrown = ExpectedException.none();
+
+ @Test
+ public void test() throws Exception {
+ StreamExecutionEnvironment env =
MLEnvironmentFactory.getDefault().getStreamExecutionEnvironment();
+
+ DataStream input = env.fromElements(Row.of("a"));
+
+ Table table1 =
DataStreamConversionUtil.toTable(MLEnvironmentFactory.DEFAULT_ML_ENVIRONMENT_ID,
input, new String[]{"word"});
+ Assert.assertEquals(
+ new TableSchema(new String[]{"word"}, new
TypeInformation[]{TypeInformation.of(String.class)}),
+ table1.getSchema()
+ );
+
+ input = input.map(new GenericTypeMap());
+
+ Table table2 = DataStreamConversionUtil.toTable(
+ MLEnvironmentFactory.DEFAULT_ML_ENVIRONMENT_ID,
+ input,
+ new String[]{"word"},
+ new TypeInformation[]{TypeInformation.of(Integer.class)}
Review comment:
`Integer.class` cannot be case to `String.class` obviously, however this
`toTable` call is not throwing any exception, is this expected?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add two utils for Table transformations
walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add
two utils for Table transformations
URL: https://github.com/apache/flink/pull/9373#discussion_r362246988
##
File path:
flink-ml-parent/flink-ml-lib/src/test/java/org/apache/flink/ml/common/utils/DataStreamConversionUtilTest.java
##
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.ml.common.utils;
+
+import org.apache.flink.api.common.functions.MapFunction;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.ml.common.MLEnvironmentFactory;
+import org.apache.flink.streaming.api.datastream.DataStream;
+import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
+import org.apache.flink.table.api.Table;
+import org.apache.flink.table.api.TableSchema;
+import org.apache.flink.table.api.ValidationException;
+import org.apache.flink.types.Row;
+
+import org.junit.Assert;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.rules.ExpectedException;
+
+/**
+ * Unit Test for DataStreamConversionUtil.
+ */
+public class DataStreamConversionUtilTest {
+ @Rule
+ public ExpectedException thrown = ExpectedException.none();
+
+ @Test
+ public void test() throws Exception {
+ StreamExecutionEnvironment env =
MLEnvironmentFactory.getDefault().getStreamExecutionEnvironment();
+
+ DataStream input = env.fromElements(Row.of("a"));
+
+ Table table1 =
DataStreamConversionUtil.toTable(MLEnvironmentFactory.DEFAULT_ML_ENVIRONMENT_ID,
input, new String[]{"word"});
+ Assert.assertEquals(
+ new TableSchema(new String[]{"word"}, new
TypeInformation[]{TypeInformation.of(String.class)}),
+ table1.getSchema()
+ );
+
+ input = input.map(new GenericTypeMap());
+
+ Table table2 = DataStreamConversionUtil.toTable(
+ MLEnvironmentFactory.DEFAULT_ML_ENVIRONMENT_ID,
+ input,
+ new String[]{"word"},
+ new TypeInformation[]{TypeInformation.of(Integer.class)}
+ );
+
+ Assert.assertEquals(
+ new TableSchema(new String[]{"word"}, new
TypeInformation[]{TypeInformation.of(Integer.class)}),
+ table2.getSchema()
+ );
+
+ Table tableFromDataStreamWithTableSchema =
DataStreamConversionUtil.toTable(
+ MLEnvironmentFactory.DEFAULT_ML_ENVIRONMENT_ID,
+ input,
+ new TableSchema(
+ new String[]{"word"},
+ new
TypeInformation[]{TypeInformation.of(Integer.class)}
+ )
+ );
+
+ Assert.assertEquals(
+ new TableSchema(new String[]{"word"}, new
TypeInformation[]{TypeInformation.of(Integer.class)}),
+ tableFromDataStreamWithTableSchema.getSchema()
+ );
+
+ thrown.expect(ValidationException.class);
+
DataStreamConversionUtil.toTable(MLEnvironmentFactory.DEFAULT_ML_ENVIRONMENT_ID,
input, new String[]{"f0"});
Review comment:
is this exception expected to be thrown because of "f0" not found? the
exception thrown here is:
```
An input of GenericTypeInfo cannot be converted to Table. Please
specify the type of the input with a RowTypeInfo.
```
instead of not found.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add two utils for Table transformations
walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add
two utils for Table transformations
URL: https://github.com/apache/flink/pull/9373#discussion_r362237999
##
File path:
flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/common/utils/DataSetConversionUtil.java
##
@@ -0,0 +1,172 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.ml.common.utils;
+
+import org.apache.flink.api.common.functions.MapFunction;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.java.DataSet;
+import org.apache.flink.api.java.operators.SingleInputUdfOperator;
+import org.apache.flink.api.java.operators.TwoInputUdfOperator;
+import org.apache.flink.api.java.typeutils.RowTypeInfo;
+import org.apache.flink.ml.common.MLEnvironment;
+import org.apache.flink.ml.common.MLEnvironmentFactory;
+import org.apache.flink.table.api.Table;
+import org.apache.flink.table.api.TableSchema;
+import org.apache.flink.table.api.ValidationException;
+import org.apache.flink.types.Row;
+
+/**
+ * Provide functions of conversions between DataSet and Table.
+ */
+public class DataSetConversionUtil {
+ /**
+* Convert the given Table to {@link DataSet}<{@link Row}>.
+*
+* @param sessionId the sessionId of {@link MLEnvironmentFactory}
+* @param table the Table to convert.
+* @return the converted DataSet.
+*/
+ public static DataSet fromTable(Long sessionId, Table table) {
+ return MLEnvironmentFactory
+ .get(sessionId)
+ .getBatchTableEnvironment()
+ .toDataSet(table, Row.class);
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified TableSchema.
+*
+* @param sessionId the sessionId of {@link MLEnvironmentFactory}
+* @param data the DataSet to convert.
+* @param schema the specified TableSchema.
+* @return the converted Table.
+*/
+ public static Table toTable(Long sessionId, DataSet data,
TableSchema schema) {
+ return toTable(sessionId, data, schema.getFieldNames(),
schema.getFieldTypes());
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified colNames and
colTypes.
+*
+* @param sessionId sessionId the sessionId of {@link
MLEnvironmentFactory}.
+* @param data the DataSet to convert.
+* @param colNames the specified colNames.
+* @param colTypes the specified colTypes. This variable is used only
when the
+* DataSet is produced by a function and Flink cannot
determine
+* automatically what the produced type is.
+* @return the converted Table.
+*/
+ public static Table toTable(Long sessionId, DataSet data,
String[] colNames, TypeInformation [] colTypes) {
+ return toTable(MLEnvironmentFactory.get(sessionId), data,
colNames, colTypes);
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified colNames.
+*
+* @param sessionId sessionId the sessionId of {@link
MLEnvironmentFactory}.
+* @param data the DataSet to convert.
+* @param colNames the specified colNames.
+* @return the converted Table.
+*/
+ public static Table toTable(Long sessionId, DataSet data,
String[] colNames) {
+ return toTable(MLEnvironmentFactory.get(sessionId), data,
colNames);
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified colNames and
colTypes.
+*
+* @param session the MLEnvironment using to convert DataSet to Table.
+* @param data the DataSet to convert.
+* @param colNames the specified colNames.
+* @param colTypes the specified colTypes. This variable is used only
when the
+* DataSet is produced by a function and Flink cannot
determine
+* automatically what the produced type is.
+* @return the converted Table.
+*/
+ public st
[GitHub] [flink] walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add two utils for Table transformations
walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add
two utils for Table transformations
URL: https://github.com/apache/flink/pull/9373#discussion_r362075816
##
File path:
flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/common/utils/DataSetConversionUtil.java
##
@@ -0,0 +1,172 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.ml.common.utils;
+
+import org.apache.flink.api.common.functions.MapFunction;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.java.DataSet;
+import org.apache.flink.api.java.operators.SingleInputUdfOperator;
+import org.apache.flink.api.java.operators.TwoInputUdfOperator;
+import org.apache.flink.api.java.typeutils.RowTypeInfo;
+import org.apache.flink.ml.common.MLEnvironment;
+import org.apache.flink.ml.common.MLEnvironmentFactory;
+import org.apache.flink.table.api.Table;
+import org.apache.flink.table.api.TableSchema;
+import org.apache.flink.table.api.ValidationException;
+import org.apache.flink.types.Row;
+
+/**
+ * Provide functions of conversions between DataSet and Table.
+ */
+public class DataSetConversionUtil {
+ /**
+* Convert the given Table to {@link DataSet}<{@link Row}>.
+*
+* @param sessionId the sessionId of {@link MLEnvironmentFactory}
+* @param table the Table to convert.
+* @return the converted DataSet.
+*/
+ public static DataSet fromTable(Long sessionId, Table table) {
+ return MLEnvironmentFactory
+ .get(sessionId)
+ .getBatchTableEnvironment()
+ .toDataSet(table, Row.class);
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified TableSchema.
+*
+* @param sessionId the sessionId of {@link MLEnvironmentFactory}
+* @param data the DataSet to convert.
+* @param schema the specified TableSchema.
+* @return the converted Table.
+*/
+ public static Table toTable(Long sessionId, DataSet data,
TableSchema schema) {
+ return toTable(sessionId, data, schema.getFieldNames(),
schema.getFieldTypes());
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified colNames and
colTypes.
+*
+* @param sessionId sessionId the sessionId of {@link
MLEnvironmentFactory}.
+* @param data the DataSet to convert.
+* @param colNames the specified colNames.
+* @param colTypes the specified colTypes. This variable is used only
when the
+* DataSet is produced by a function and Flink cannot
determine
+* automatically what the produced type is.
+* @return the converted Table.
+*/
+ public static Table toTable(Long sessionId, DataSet data,
String[] colNames, TypeInformation [] colTypes) {
+ return toTable(MLEnvironmentFactory.get(sessionId), data,
colNames, colTypes);
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified colNames.
+*
+* @param sessionId sessionId the sessionId of {@link
MLEnvironmentFactory}.
+* @param data the DataSet to convert.
+* @param colNames the specified colNames.
+* @return the converted Table.
+*/
+ public static Table toTable(Long sessionId, DataSet data,
String[] colNames) {
+ return toTable(MLEnvironmentFactory.get(sessionId), data,
colNames);
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified colNames and
colTypes.
+*
+* @param session the MLEnvironment using to convert DataSet to Table.
+* @param data the DataSet to convert.
+* @param colNames the specified colNames.
+* @param colTypes the specified colTypes. This variable is used only
when the
+* DataSet is produced by a function and Flink cannot
determine
+* automatically what the produced type is.
+* @return the converted Table.
+*/
+ public st
[GitHub] [flink] walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add two utils for Table transformations
walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add
two utils for Table transformations
URL: https://github.com/apache/flink/pull/9373#discussion_r361802372
##
File path:
flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/common/utils/DataSetConversionUtil.java
##
@@ -0,0 +1,172 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.ml.common.utils;
+
+import org.apache.flink.api.common.functions.MapFunction;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.java.DataSet;
+import org.apache.flink.api.java.operators.SingleInputUdfOperator;
+import org.apache.flink.api.java.operators.TwoInputUdfOperator;
+import org.apache.flink.api.java.typeutils.RowTypeInfo;
+import org.apache.flink.ml.common.MLEnvironment;
+import org.apache.flink.ml.common.MLEnvironmentFactory;
+import org.apache.flink.table.api.Table;
+import org.apache.flink.table.api.TableSchema;
+import org.apache.flink.table.api.ValidationException;
+import org.apache.flink.types.Row;
+
+/**
+ * Provide functions of conversions between DataSet and Table.
+ */
+public class DataSetConversionUtil {
+ /**
+* Convert the given Table to {@link DataSet}<{@link Row}>.
+*
+* @param sessionId the sessionId of {@link MLEnvironmentFactory}
+* @param table the Table to convert.
+* @return the converted DataSet.
+*/
+ public static DataSet fromTable(Long sessionId, Table table) {
+ return MLEnvironmentFactory
+ .get(sessionId)
+ .getBatchTableEnvironment()
+ .toDataSet(table, Row.class);
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified TableSchema.
+*
+* @param sessionId the sessionId of {@link MLEnvironmentFactory}
+* @param data the DataSet to convert.
+* @param schema the specified TableSchema.
+* @return the converted Table.
+*/
+ public static Table toTable(Long sessionId, DataSet data,
TableSchema schema) {
+ return toTable(sessionId, data, schema.getFieldNames(),
schema.getFieldTypes());
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified colNames and
colTypes.
+*
+* @param sessionId sessionId the sessionId of {@link
MLEnvironmentFactory}.
+* @param data the DataSet to convert.
+* @param colNames the specified colNames.
+* @param colTypes the specified colTypes. This variable is used only
when the
+* DataSet is produced by a function and Flink cannot
determine
+* automatically what the produced type is.
+* @return the converted Table.
+*/
+ public static Table toTable(Long sessionId, DataSet data,
String[] colNames, TypeInformation [] colTypes) {
+ return toTable(MLEnvironmentFactory.get(sessionId), data,
colNames, colTypes);
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified colNames.
+*
+* @param sessionId sessionId the sessionId of {@link
MLEnvironmentFactory}.
+* @param data the DataSet to convert.
+* @param colNames the specified colNames.
+* @return the converted Table.
+*/
+ public static Table toTable(Long sessionId, DataSet data,
String[] colNames) {
+ return toTable(MLEnvironmentFactory.get(sessionId), data,
colNames);
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified colNames and
colTypes.
+*
+* @param session the MLEnvironment using to convert DataSet to Table.
+* @param data the DataSet to convert.
+* @param colNames the specified colNames.
+* @param colTypes the specified colTypes. This variable is used only
when the
+* DataSet is produced by a function and Flink cannot
determine
+* automatically what the produced type is.
+* @return the converted Table.
+*/
+ public st
[GitHub] [flink] walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add two utils for Table transformations
walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add
two utils for Table transformations
URL: https://github.com/apache/flink/pull/9373#discussion_r361699910
##
File path:
flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/common/utils/DataSetConversionUtil.java
##
@@ -0,0 +1,171 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.ml.common.utils;
+
+import org.apache.flink.api.common.functions.MapFunction;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.java.DataSet;
+import org.apache.flink.api.java.operators.SingleInputUdfOperator;
+import org.apache.flink.api.java.operators.TwoInputUdfOperator;
+import org.apache.flink.api.java.typeutils.RowTypeInfo;
+import org.apache.flink.ml.common.MLEnvironment;
+import org.apache.flink.ml.common.MLEnvironmentFactory;
+import org.apache.flink.table.api.Table;
+import org.apache.flink.table.api.TableSchema;
+import org.apache.flink.types.Row;
+
+/**
+ * Provide functions of conversions between DataSet and Table.
+ */
+public class DataSetConversionUtil {
+ /**
+* Convert the given Table to {@link DataSet}<{@link Row}>.
+*
+* @param sessionId the sessionId of {@link MLEnvironmentFactory}
+* @param table the Table to convert.
+* @return the converted DataSet.
+*/
+ public static DataSet fromTable(Long sessionId, Table table) {
+ return MLEnvironmentFactory
+ .get(sessionId)
+ .getBatchTableEnvironment()
+ .toDataSet(table, Row.class);
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified TableSchema.
+*
+* @param sessionId the sessionId of {@link MLEnvironmentFactory}
+* @param data the DataSet to convert.
+* @param schema the specified TableSchema.
+* @return the converted Table.
+*/
+ public static Table toTable(Long sessionId, DataSet data,
TableSchema schema) {
Review comment:
I would add some comments here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add two utils for Table transformations
walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add
two utils for Table transformations
URL: https://github.com/apache/flink/pull/9373#discussion_r361699849
##
File path:
flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/common/utils/DataSetConversionUtil.java
##
@@ -0,0 +1,172 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.ml.common.utils;
+
+import org.apache.flink.api.common.functions.MapFunction;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.java.DataSet;
+import org.apache.flink.api.java.operators.SingleInputUdfOperator;
+import org.apache.flink.api.java.operators.TwoInputUdfOperator;
+import org.apache.flink.api.java.typeutils.RowTypeInfo;
+import org.apache.flink.ml.common.MLEnvironment;
+import org.apache.flink.ml.common.MLEnvironmentFactory;
+import org.apache.flink.table.api.Table;
+import org.apache.flink.table.api.TableSchema;
+import org.apache.flink.table.api.ValidationException;
+import org.apache.flink.types.Row;
+
+/**
+ * Provide functions of conversions between DataSet and Table.
+ */
+public class DataSetConversionUtil {
+ /**
+* Convert the given Table to {@link DataSet}<{@link Row}>.
+*
+* @param sessionId the sessionId of {@link MLEnvironmentFactory}
+* @param table the Table to convert.
+* @return the converted DataSet.
+*/
+ public static DataSet fromTable(Long sessionId, Table table) {
+ return MLEnvironmentFactory
+ .get(sessionId)
+ .getBatchTableEnvironment()
+ .toDataSet(table, Row.class);
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified TableSchema.
+*
+* @param sessionId the sessionId of {@link MLEnvironmentFactory}
+* @param data the DataSet to convert.
+* @param schema the specified TableSchema.
+* @return the converted Table.
+*/
+ public static Table toTable(Long sessionId, DataSet data,
TableSchema schema) {
+ return toTable(sessionId, data, schema.getFieldNames(),
schema.getFieldTypes());
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified colNames and
colTypes.
+*
+* @param sessionId sessionId the sessionId of {@link
MLEnvironmentFactory}.
+* @param data the DataSet to convert.
+* @param colNames the specified colNames.
+* @param colTypes the specified colTypes. This variable is used only
when the
+* DataSet is produced by a function and Flink cannot
determine
+* automatically what the produced type is.
+* @return the converted Table.
+*/
+ public static Table toTable(Long sessionId, DataSet data,
String[] colNames, TypeInformation [] colTypes) {
+ return toTable(MLEnvironmentFactory.get(sessionId), data,
colNames, colTypes);
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified colNames.
+*
+* @param sessionId sessionId the sessionId of {@link
MLEnvironmentFactory}.
+* @param data the DataSet to convert.
+* @param colNames the specified colNames.
+* @return the converted Table.
+*/
+ public static Table toTable(Long sessionId, DataSet data,
String[] colNames) {
+ return toTable(MLEnvironmentFactory.get(sessionId), data,
colNames);
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified colNames and
colTypes.
+*
+* @param session the MLEnvironment using to convert DataSet to Table.
+* @param data the DataSet to convert.
+* @param colNames the specified colNames.
+* @param colTypes the specified colTypes. This variable is used only
when the
+* DataSet is produced by a function and Flink cannot
determine
+* automatically what the produced type is.
+* @return the converted Table.
+*/
+ public st
[GitHub] [flink] walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add two utils for Table transformations
walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add
two utils for Table transformations
URL: https://github.com/apache/flink/pull/9373#discussion_r361699961
##
File path:
flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/common/utils/DataSetConversionUtil.java
##
@@ -0,0 +1,171 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.ml.common.utils;
+
+import org.apache.flink.api.common.functions.MapFunction;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.java.DataSet;
+import org.apache.flink.api.java.operators.SingleInputUdfOperator;
+import org.apache.flink.api.java.operators.TwoInputUdfOperator;
+import org.apache.flink.api.java.typeutils.RowTypeInfo;
+import org.apache.flink.ml.common.MLEnvironment;
+import org.apache.flink.ml.common.MLEnvironmentFactory;
+import org.apache.flink.table.api.Table;
+import org.apache.flink.table.api.TableSchema;
+import org.apache.flink.types.Row;
+
+/**
+ * Provide functions of conversions between DataSet and Table.
+ */
+public class DataSetConversionUtil {
+ /**
+* Convert the given Table to {@link DataSet}<{@link Row}>.
+*
+* @param sessionId the sessionId of {@link MLEnvironmentFactory}
+* @param table the Table to convert.
+* @return the converted DataSet.
+*/
+ public static DataSet fromTable(Long sessionId, Table table) {
+ return MLEnvironmentFactory
+ .get(sessionId)
+ .getBatchTableEnvironment()
+ .toDataSet(table, Row.class);
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified TableSchema.
+*
+* @param sessionId the sessionId of {@link MLEnvironmentFactory}
+* @param data the DataSet to convert.
+* @param schema the specified TableSchema.
+* @return the converted Table.
+*/
+ public static Table toTable(Long sessionId, DataSet data,
TableSchema schema) {
+ return toTable(sessionId, data, schema.getFieldNames(),
schema.getFieldTypes());
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified colNames and
colTypes.
+*
+* @param sessionId sessionId the sessionId of {@link
MLEnvironmentFactory}.
+* @param data the DataSet to convert.
+* @param colNames the specified colNames.
+* @param colTypes the specified colTypes. This variable is used only
when the
+* DataSet is produced by a function and Flink cannot
determine
+* automatically what the produced type is.
+* @return the converted Table.
+*/
+ public static Table toTable(Long sessionId, DataSet data,
String[] colNames, TypeInformation [] colTypes) {
+ return toTable(MLEnvironmentFactory.get(sessionId), data,
colNames, colTypes);
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified colNames.
+*
+* @param sessionId sessionId the sessionId of {@link
MLEnvironmentFactory}.
+* @param data the DataSet to convert.
+* @param colNames the specified colNames.
+* @return the converted Table.
+*/
+ public static Table toTable(Long sessionId, DataSet data,
String[] colNames) {
+ return toTable(MLEnvironmentFactory.get(sessionId), data,
colNames);
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified colNames and
colTypes.
+*
+* @param session the MLEnvironment using to convert DataSet to Table.
+* @param data the DataSet to convert.
+* @param colNames the specified colNames.
+* @param colTypes the specified colTypes. This variable is used only
when the
+* DataSet is produced by a function and Flink cannot
determine
+* automatically what the produced type is.
+* @return the converted Table.
+*/
+ public static Table toTable(MLEnvironment session, DataSet data,
[GitHub] [flink] walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add two utils for Table transformations
walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add
two utils for Table transformations
URL: https://github.com/apache/flink/pull/9373#discussion_r361700199
##
File path:
flink-ml-parent/flink-ml-lib/src/test/java/org/apache/flink/ml/common/utils/DataStreamConversionUtilTest.java
##
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.ml.common.utils;
+
+import org.apache.flink.api.common.functions.MapFunction;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.ml.common.MLEnvironmentFactory;
+import org.apache.flink.streaming.api.datastream.DataStream;
+import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
+import org.apache.flink.table.api.Table;
+import org.apache.flink.table.api.TableSchema;
+import org.apache.flink.table.api.ValidationException;
+import org.apache.flink.types.Row;
+
+import org.junit.Assert;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.rules.ExpectedException;
+
+/**
+ * Unit Test for DataStreamConversionUtil.
+ */
+public class DataStreamConversionUtilTest {
+ @Rule
+ public ExpectedException thrown = ExpectedException.none();
+
+ @Test
+ public void test() throws Exception {
Review comment:
I would make sure this end to end test and the per-API test in DataSet Util
exist in both side when merging.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add two utils for Table transformations
walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add
two utils for Table transformations
URL: https://github.com/apache/flink/pull/9373#discussion_r361487088
##
File path:
flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/common/utils/DataSetConversionUtil.java
##
@@ -0,0 +1,172 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.ml.common.utils;
+
+import org.apache.flink.api.common.functions.MapFunction;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.java.DataSet;
+import org.apache.flink.api.java.operators.SingleInputUdfOperator;
+import org.apache.flink.api.java.operators.TwoInputUdfOperator;
+import org.apache.flink.api.java.typeutils.RowTypeInfo;
+import org.apache.flink.ml.common.MLEnvironment;
+import org.apache.flink.ml.common.MLEnvironmentFactory;
+import org.apache.flink.table.api.Table;
+import org.apache.flink.table.api.TableSchema;
+import org.apache.flink.table.api.ValidationException;
+import org.apache.flink.types.Row;
+
+/**
+ * Provide functions of conversions between DataSet and Table.
+ */
+public class DataSetConversionUtil {
+ /**
+* Convert the given Table to {@link DataSet}<{@link Row}>.
+*
+* @param sessionId the sessionId of {@link MLEnvironmentFactory}
+* @param table the Table to convert.
+* @return the converted DataSet.
+*/
+ public static DataSet fromTable(Long sessionId, Table table) {
+ return MLEnvironmentFactory
+ .get(sessionId)
+ .getBatchTableEnvironment()
+ .toDataSet(table, Row.class);
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified TableSchema.
+*
+* @param sessionId the sessionId of {@link MLEnvironmentFactory}
+* @param data the DataSet to convert.
+* @param schema the specified TableSchema.
+* @return the converted Table.
+*/
+ public static Table toTable(Long sessionId, DataSet data,
TableSchema schema) {
+ return toTable(sessionId, data, schema.getFieldNames(),
schema.getFieldTypes());
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified colNames and
colTypes.
+*
+* @param sessionId sessionId the sessionId of {@link
MLEnvironmentFactory}.
+* @param data the DataSet to convert.
+* @param colNames the specified colNames.
+* @param colTypes the specified colTypes. This variable is used only
when the
+* DataSet is produced by a function and Flink cannot
determine
+* automatically what the produced type is.
+* @return the converted Table.
+*/
+ public static Table toTable(Long sessionId, DataSet data,
String[] colNames, TypeInformation [] colTypes) {
+ return toTable(MLEnvironmentFactory.get(sessionId), data,
colNames, colTypes);
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified colNames.
+*
+* @param sessionId sessionId the sessionId of {@link
MLEnvironmentFactory}.
+* @param data the DataSet to convert.
+* @param colNames the specified colNames.
+* @return the converted Table.
+*/
+ public static Table toTable(Long sessionId, DataSet data,
String[] colNames) {
+ return toTable(MLEnvironmentFactory.get(sessionId), data,
colNames);
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified colNames and
colTypes.
+*
+* @param session the MLEnvironment using to convert DataSet to Table.
+* @param data the DataSet to convert.
+* @param colNames the specified colNames.
+* @param colTypes the specified colTypes. This variable is used only
when the
+* DataSet is produced by a function and Flink cannot
determine
+* automatically what the produced type is.
+* @return the converted Table.
+*/
+ public st
[GitHub] [flink] walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add two utils for Table transformations
walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add
two utils for Table transformations
URL: https://github.com/apache/flink/pull/9373#discussion_r360661267
##
File path:
flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/common/utils/DataSetConversionUtil.java
##
@@ -0,0 +1,172 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.ml.common.utils;
+
+import org.apache.flink.api.common.functions.MapFunction;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.java.DataSet;
+import org.apache.flink.api.java.operators.SingleInputUdfOperator;
+import org.apache.flink.api.java.operators.TwoInputUdfOperator;
+import org.apache.flink.api.java.typeutils.RowTypeInfo;
+import org.apache.flink.ml.common.MLEnvironment;
+import org.apache.flink.ml.common.MLEnvironmentFactory;
+import org.apache.flink.table.api.Table;
+import org.apache.flink.table.api.TableSchema;
+import org.apache.flink.table.api.ValidationException;
+import org.apache.flink.types.Row;
+
+/**
+ * Provide functions of conversions between DataSet and Table.
+ */
+public class DataSetConversionUtil {
+ /**
+* Convert the given Table to {@link DataSet}<{@link Row}>.
+*
+* @param sessionId the sessionId of {@link MLEnvironmentFactory}
+* @param table the Table to convert.
+* @return the converted DataSet.
+*/
+ public static DataSet fromTable(Long sessionId, Table table) {
+ return MLEnvironmentFactory
+ .get(sessionId)
+ .getBatchTableEnvironment()
+ .toDataSet(table, Row.class);
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified TableSchema.
+*
+* @param sessionId the sessionId of {@link MLEnvironmentFactory}
+* @param data the DataSet to convert.
+* @param schema the specified TableSchema.
+* @return the converted Table.
+*/
+ public static Table toTable(Long sessionId, DataSet data,
TableSchema schema) {
+ return toTable(sessionId, data, schema.getFieldNames(),
schema.getFieldTypes());
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified colNames and
colTypes.
+*
+* @param sessionId sessionId the sessionId of {@link
MLEnvironmentFactory}.
+* @param data the DataSet to convert.
+* @param colNames the specified colNames.
+* @param colTypes the specified colTypes. This variable is used only
when the
+* DataSet is produced by a function and Flink cannot
determine
+* automatically what the produced type is.
+* @return the converted Table.
+*/
+ public static Table toTable(Long sessionId, DataSet data,
String[] colNames, TypeInformation [] colTypes) {
+ return toTable(MLEnvironmentFactory.get(sessionId), data,
colNames, colTypes);
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified colNames.
+*
+* @param sessionId sessionId the sessionId of {@link
MLEnvironmentFactory}.
+* @param data the DataSet to convert.
+* @param colNames the specified colNames.
+* @return the converted Table.
+*/
+ public static Table toTable(Long sessionId, DataSet data,
String[] colNames) {
+ return toTable(MLEnvironmentFactory.get(sessionId), data,
colNames);
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified colNames and
colTypes.
+*
+* @param session the MLEnvironment using to convert DataSet to Table.
+* @param data the DataSet to convert.
+* @param colNames the specified colNames.
+* @param colTypes the specified colTypes. This variable is used only
when the
+* DataSet is produced by a function and Flink cannot
determine
+* automatically what the produced type is.
+* @return the converted Table.
+*/
+ public st
[GitHub] [flink] walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add two utils for Table transformations
walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add
two utils for Table transformations
URL: https://github.com/apache/flink/pull/9373#discussion_r344817772
##
File path:
flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/common/utils/DataSetConversionUtil.java
##
@@ -0,0 +1,171 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.ml.common.utils;
+
+import org.apache.flink.api.common.functions.MapFunction;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.java.DataSet;
+import org.apache.flink.api.java.operators.SingleInputUdfOperator;
+import org.apache.flink.api.java.operators.TwoInputUdfOperator;
+import org.apache.flink.api.java.typeutils.RowTypeInfo;
+import org.apache.flink.ml.common.MLEnvironment;
+import org.apache.flink.ml.common.MLEnvironmentFactory;
+import org.apache.flink.table.api.Table;
+import org.apache.flink.table.api.TableSchema;
+import org.apache.flink.types.Row;
+
+/**
+ * Provide functions of conversions between DataSet and Table.
+ */
+public class DataSetConversionUtil {
+ /**
+* Convert the given Table to {@link DataSet}<{@link Row}>.
+*
+* @param sessionId the sessionId of {@link MLEnvironmentFactory}
+* @param table the Table to convert.
+* @return the converted DataSet.
+*/
+ public static DataSet fromTable(Long sessionId, Table table) {
+ return MLEnvironmentFactory
+ .get(sessionId)
+ .getBatchTableEnvironment()
+ .toDataSet(table, Row.class);
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified TableSchema.
+*
+* @param sessionId the sessionId of {@link MLEnvironmentFactory}
+* @param data the DataSet to convert.
+* @param schema the specified TableSchema.
+* @return the converted Table.
+*/
+ public static Table toTable(Long sessionId, DataSet data,
TableSchema schema) {
+ return toTable(sessionId, data, schema.getFieldNames(),
schema.getFieldTypes());
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified colNames and
colTypes.
+*
+* @param sessionId sessionId the sessionId of {@link
MLEnvironmentFactory}.
+* @param data the DataSet to convert.
+* @param colNames the specified colNames.
+* @param colTypes the specified colTypes. This variable is used only
when the
+* DataSet is produced by a function and Flink cannot
determine
+* automatically what the produced type is.
+* @return the converted Table.
+*/
+ public static Table toTable(Long sessionId, DataSet data,
String[] colNames, TypeInformation [] colTypes) {
+ return toTable(MLEnvironmentFactory.get(sessionId), data,
colNames, colTypes);
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified colNames.
+*
+* @param sessionId sessionId the sessionId of {@link
MLEnvironmentFactory}.
+* @param data the DataSet to convert.
+* @param colNames the specified colNames.
+* @return the converted Table.
+*/
+ public static Table toTable(Long sessionId, DataSet data,
String[] colNames) {
+ return toTable(MLEnvironmentFactory.get(sessionId), data,
colNames);
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified colNames and
colTypes.
+*
+* @param session the MLEnvironment using to convert DataSet to Table.
+* @param data the DataSet to convert.
+* @param colNames the specified colNames.
+* @param colTypes the specified colTypes. This variable is used only
when the
+* DataSet is produced by a function and Flink cannot
determine
+* automatically what the produced type is.
+* @return the converted Table.
+*/
+ public static Table toTable(MLEnvironment session, DataSet data,
[GitHub] [flink] walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add two utils for Table transformations
walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add
two utils for Table transformations
URL: https://github.com/apache/flink/pull/9373#discussion_r344469287
##
File path:
flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/common/utils/DataSetConversionUtil.java
##
@@ -0,0 +1,171 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.ml.common.utils;
+
+import org.apache.flink.api.common.functions.MapFunction;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.java.DataSet;
+import org.apache.flink.api.java.operators.SingleInputUdfOperator;
+import org.apache.flink.api.java.operators.TwoInputUdfOperator;
+import org.apache.flink.api.java.typeutils.RowTypeInfo;
+import org.apache.flink.ml.common.MLEnvironment;
+import org.apache.flink.ml.common.MLEnvironmentFactory;
+import org.apache.flink.table.api.Table;
+import org.apache.flink.table.api.TableSchema;
+import org.apache.flink.types.Row;
+
+/**
+ * Provide functions of conversions between DataSet and Table.
+ */
+public class DataSetConversionUtil {
+ /**
+* Convert the given Table to {@link DataSet}<{@link Row}>.
+*
+* @param sessionId the sessionId of {@link MLEnvironmentFactory}
+* @param table the Table to convert.
+* @return the converted DataSet.
+*/
+ public static DataSet fromTable(Long sessionId, Table table) {
+ return MLEnvironmentFactory
+ .get(sessionId)
+ .getBatchTableEnvironment()
+ .toDataSet(table, Row.class);
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified TableSchema.
+*
+* @param sessionId the sessionId of {@link MLEnvironmentFactory}
+* @param data the DataSet to convert.
+* @param schema the specified TableSchema.
+* @return the converted Table.
+*/
+ public static Table toTable(Long sessionId, DataSet data,
TableSchema schema) {
+ return toTable(sessionId, data, schema.getFieldNames(),
schema.getFieldTypes());
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified colNames and
colTypes.
+*
+* @param sessionId sessionId the sessionId of {@link
MLEnvironmentFactory}.
+* @param data the DataSet to convert.
+* @param colNames the specified colNames.
+* @param colTypes the specified colTypes. This variable is used only
when the
+* DataSet is produced by a function and Flink cannot
determine
+* automatically what the produced type is.
+* @return the converted Table.
+*/
+ public static Table toTable(Long sessionId, DataSet data,
String[] colNames, TypeInformation [] colTypes) {
+ return toTable(MLEnvironmentFactory.get(sessionId), data,
colNames, colTypes);
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified colNames.
+*
+* @param sessionId sessionId the sessionId of {@link
MLEnvironmentFactory}.
+* @param data the DataSet to convert.
+* @param colNames the specified colNames.
+* @return the converted Table.
+*/
+ public static Table toTable(Long sessionId, DataSet data,
String[] colNames) {
+ return toTable(MLEnvironmentFactory.get(sessionId), data,
colNames);
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified colNames and
colTypes.
+*
+* @param session the MLEnvironment using to convert DataSet to Table.
+* @param data the DataSet to convert.
+* @param colNames the specified colNames.
+* @param colTypes the specified colTypes. This variable is used only
when the
+* DataSet is produced by a function and Flink cannot
determine
+* automatically what the produced type is.
+* @return the converted Table.
+*/
+ public static Table toTable(MLEnvironment session, DataSet data,
[GitHub] [flink] walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add two utils for Table transformations
walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add
two utils for Table transformations
URL: https://github.com/apache/flink/pull/9373#discussion_r344469261
##
File path:
flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/common/utils/DataSetConversionUtil.java
##
@@ -0,0 +1,171 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.ml.common.utils;
+
+import org.apache.flink.api.common.functions.MapFunction;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.java.DataSet;
+import org.apache.flink.api.java.operators.SingleInputUdfOperator;
+import org.apache.flink.api.java.operators.TwoInputUdfOperator;
+import org.apache.flink.api.java.typeutils.RowTypeInfo;
+import org.apache.flink.ml.common.MLEnvironment;
+import org.apache.flink.ml.common.MLEnvironmentFactory;
+import org.apache.flink.table.api.Table;
+import org.apache.flink.table.api.TableSchema;
+import org.apache.flink.types.Row;
+
+/**
+ * Provide functions of conversions between DataSet and Table.
+ */
+public class DataSetConversionUtil {
+ /**
+* Convert the given Table to {@link DataSet}<{@link Row}>.
+*
+* @param sessionId the sessionId of {@link MLEnvironmentFactory}
+* @param table the Table to convert.
+* @return the converted DataSet.
+*/
+ public static DataSet fromTable(Long sessionId, Table table) {
+ return MLEnvironmentFactory
+ .get(sessionId)
+ .getBatchTableEnvironment()
+ .toDataSet(table, Row.class);
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified TableSchema.
+*
+* @param sessionId the sessionId of {@link MLEnvironmentFactory}
+* @param data the DataSet to convert.
+* @param schema the specified TableSchema.
+* @return the converted Table.
+*/
+ public static Table toTable(Long sessionId, DataSet data,
TableSchema schema) {
+ return toTable(sessionId, data, schema.getFieldNames(),
schema.getFieldTypes());
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified colNames and
colTypes.
+*
+* @param sessionId sessionId the sessionId of {@link
MLEnvironmentFactory}.
+* @param data the DataSet to convert.
+* @param colNames the specified colNames.
+* @param colTypes the specified colTypes. This variable is used only
when the
+* DataSet is produced by a function and Flink cannot
determine
+* automatically what the produced type is.
+* @return the converted Table.
+*/
+ public static Table toTable(Long sessionId, DataSet data,
String[] colNames, TypeInformation [] colTypes) {
+ return toTable(MLEnvironmentFactory.get(sessionId), data,
colNames, colTypes);
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified colNames.
+*
+* @param sessionId sessionId the sessionId of {@link
MLEnvironmentFactory}.
+* @param data the DataSet to convert.
+* @param colNames the specified colNames.
+* @return the converted Table.
+*/
+ public static Table toTable(Long sessionId, DataSet data,
String[] colNames) {
+ return toTable(MLEnvironmentFactory.get(sessionId), data,
colNames);
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified colNames and
colTypes.
+*
+* @param session the MLEnvironment using to convert DataSet to Table.
+* @param data the DataSet to convert.
+* @param colNames the specified colNames.
+* @param colTypes the specified colTypes. This variable is used only
when the
+* DataSet is produced by a function and Flink cannot
determine
+* automatically what the produced type is.
+* @return the converted Table.
+*/
+ public static Table toTable(MLEnvironment session, DataSet data,
[GitHub] [flink] walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add two utils for Table transformations
walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add
two utils for Table transformations
URL: https://github.com/apache/flink/pull/9373#discussion_r344469217
##
File path:
flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/common/utils/DataSetConversionUtil.java
##
@@ -0,0 +1,171 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.ml.common.utils;
+
+import org.apache.flink.api.common.functions.MapFunction;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.java.DataSet;
+import org.apache.flink.api.java.operators.SingleInputUdfOperator;
+import org.apache.flink.api.java.operators.TwoInputUdfOperator;
+import org.apache.flink.api.java.typeutils.RowTypeInfo;
+import org.apache.flink.ml.common.MLEnvironment;
+import org.apache.flink.ml.common.MLEnvironmentFactory;
+import org.apache.flink.table.api.Table;
+import org.apache.flink.table.api.TableSchema;
+import org.apache.flink.types.Row;
+
+/**
+ * Provide functions of conversions between DataSet and Table.
+ */
+public class DataSetConversionUtil {
+ /**
+* Convert the given Table to {@link DataSet}<{@link Row}>.
+*
+* @param sessionId the sessionId of {@link MLEnvironmentFactory}
+* @param table the Table to convert.
+* @return the converted DataSet.
+*/
+ public static DataSet fromTable(Long sessionId, Table table) {
+ return MLEnvironmentFactory
+ .get(sessionId)
+ .getBatchTableEnvironment()
+ .toDataSet(table, Row.class);
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified TableSchema.
+*
+* @param sessionId the sessionId of {@link MLEnvironmentFactory}
+* @param data the DataSet to convert.
+* @param schema the specified TableSchema.
+* @return the converted Table.
+*/
+ public static Table toTable(Long sessionId, DataSet data,
TableSchema schema) {
+ return toTable(sessionId, data, schema.getFieldNames(),
schema.getFieldTypes());
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified colNames and
colTypes.
+*
+* @param sessionId sessionId the sessionId of {@link
MLEnvironmentFactory}.
+* @param data the DataSet to convert.
+* @param colNames the specified colNames.
+* @param colTypes the specified colTypes. This variable is used only
when the
+* DataSet is produced by a function and Flink cannot
determine
+* automatically what the produced type is.
+* @return the converted Table.
+*/
+ public static Table toTable(Long sessionId, DataSet data,
String[] colNames, TypeInformation [] colTypes) {
+ return toTable(MLEnvironmentFactory.get(sessionId), data,
colNames, colTypes);
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified colNames.
+*
+* @param sessionId sessionId the sessionId of {@link
MLEnvironmentFactory}.
+* @param data the DataSet to convert.
+* @param colNames the specified colNames.
+* @return the converted Table.
+*/
+ public static Table toTable(Long sessionId, DataSet data,
String[] colNames) {
+ return toTable(MLEnvironmentFactory.get(sessionId), data,
colNames);
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified colNames and
colTypes.
+*
+* @param session the MLEnvironment using to convert DataSet to Table.
+* @param data the DataSet to convert.
+* @param colNames the specified colNames.
+* @param colTypes the specified colTypes. This variable is used only
when the
+* DataSet is produced by a function and Flink cannot
determine
+* automatically what the produced type is.
+* @return the converted Table.
+*/
+ public static Table toTable(MLEnvironment session, DataSet data,
[GitHub] [flink] walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add two utils for Table transformations
walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add
two utils for Table transformations
URL: https://github.com/apache/flink/pull/9373#discussion_r342376557
##
File path:
flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/common/utils/DataSetConversionUtil.java
##
@@ -0,0 +1,171 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.ml.common.utils;
+
+import org.apache.flink.api.common.functions.MapFunction;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.java.DataSet;
+import org.apache.flink.api.java.operators.SingleInputUdfOperator;
+import org.apache.flink.api.java.operators.TwoInputUdfOperator;
+import org.apache.flink.api.java.typeutils.RowTypeInfo;
+import org.apache.flink.ml.common.MLEnvironment;
+import org.apache.flink.ml.common.MLEnvironmentFactory;
+import org.apache.flink.table.api.Table;
+import org.apache.flink.table.api.TableSchema;
+import org.apache.flink.types.Row;
+
+/**
+ * Provide functions of conversions between DataSet and Table.
+ */
+public class DataSetConversionUtil {
+ /**
+* Convert the given Table to {@link DataSet}<{@link Row}>.
+*
+* @param sessionId the sessionId of {@link MLEnvironmentFactory}
+* @param table the Table to convert.
+* @return the converted DataSet.
+*/
+ public static DataSet fromTable(Long sessionId, Table table) {
+ return MLEnvironmentFactory
+ .get(sessionId)
+ .getBatchTableEnvironment()
+ .toDataSet(table, Row.class);
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified TableSchema.
+*
+* @param sessionId the sessionId of {@link MLEnvironmentFactory}
+* @param data the DataSet to convert.
+* @param schema the specified TableSchema.
+* @return the converted Table.
+*/
+ public static Table toTable(Long sessionId, DataSet data,
TableSchema schema) {
Review comment:
also if `schema.getFieldTypes()` is deprecated. I would rather we remove
this function and just allow the user to handle deprecation in user code. (this
would be much cleaner for future maintenance)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add two utils for Table transformations
walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add
two utils for Table transformations
URL: https://github.com/apache/flink/pull/9373#discussion_r342375237
##
File path:
flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/common/utils/DataSetConversionUtil.java
##
@@ -0,0 +1,171 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.ml.common.utils;
+
+import org.apache.flink.api.common.functions.MapFunction;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.java.DataSet;
+import org.apache.flink.api.java.operators.SingleInputUdfOperator;
+import org.apache.flink.api.java.operators.TwoInputUdfOperator;
+import org.apache.flink.api.java.typeutils.RowTypeInfo;
+import org.apache.flink.ml.common.MLEnvironment;
+import org.apache.flink.ml.common.MLEnvironmentFactory;
+import org.apache.flink.table.api.Table;
+import org.apache.flink.table.api.TableSchema;
+import org.apache.flink.types.Row;
+
+/**
+ * Provide functions of conversions between DataSet and Table.
+ */
+public class DataSetConversionUtil {
+ /**
+* Convert the given Table to {@link DataSet}<{@link Row}>.
+*
+* @param sessionId the sessionId of {@link MLEnvironmentFactory}
+* @param table the Table to convert.
+* @return the converted DataSet.
+*/
+ public static DataSet fromTable(Long sessionId, Table table) {
+ return MLEnvironmentFactory
+ .get(sessionId)
+ .getBatchTableEnvironment()
+ .toDataSet(table, Row.class);
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified TableSchema.
+*
+* @param sessionId the sessionId of {@link MLEnvironmentFactory}
+* @param data the DataSet to convert.
+* @param schema the specified TableSchema.
+* @return the converted Table.
+*/
+ public static Table toTable(Long sessionId, DataSet data,
TableSchema schema) {
+ return toTable(sessionId, data, schema.getFieldNames(),
schema.getFieldTypes());
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified colNames and
colTypes.
+*
+* @param sessionId sessionId the sessionId of {@link
MLEnvironmentFactory}.
+* @param data the DataSet to convert.
+* @param colNames the specified colNames.
+* @param colTypes the specified colTypes. This variable is used only
when the
+* DataSet is produced by a function and Flink cannot
determine
+* automatically what the produced type is.
+* @return the converted Table.
+*/
+ public static Table toTable(Long sessionId, DataSet data,
String[] colNames, TypeInformation [] colTypes) {
+ return toTable(MLEnvironmentFactory.get(sessionId), data,
colNames, colTypes);
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified colNames.
+*
+* @param sessionId sessionId the sessionId of {@link
MLEnvironmentFactory}.
+* @param data the DataSet to convert.
+* @param colNames the specified colNames.
+* @return the converted Table.
+*/
+ public static Table toTable(Long sessionId, DataSet data,
String[] colNames) {
+ return toTable(MLEnvironmentFactory.get(sessionId), data,
colNames);
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified colNames and
colTypes.
+*
+* @param session the MLEnvironment using to convert DataSet to Table.
+* @param data the DataSet to convert.
+* @param colNames the specified colNames.
+* @param colTypes the specified colTypes. This variable is used only
when the
+* DataSet is produced by a function and Flink cannot
determine
+* automatically what the produced type is.
+* @return the converted Table.
+*/
+ public static Table toTable(MLEnvironment session, DataSet data,
[GitHub] [flink] walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add two utils for Table transformations
walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add
two utils for Table transformations
URL: https://github.com/apache/flink/pull/9373#discussion_r342376183
##
File path:
flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/common/utils/DataSetConversionUtil.java
##
@@ -0,0 +1,171 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.ml.common.utils;
+
+import org.apache.flink.api.common.functions.MapFunction;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.java.DataSet;
+import org.apache.flink.api.java.operators.SingleInputUdfOperator;
+import org.apache.flink.api.java.operators.TwoInputUdfOperator;
+import org.apache.flink.api.java.typeutils.RowTypeInfo;
+import org.apache.flink.ml.common.MLEnvironment;
+import org.apache.flink.ml.common.MLEnvironmentFactory;
+import org.apache.flink.table.api.Table;
+import org.apache.flink.table.api.TableSchema;
+import org.apache.flink.types.Row;
+
+/**
+ * Provide functions of conversions between DataSet and Table.
+ */
+public class DataSetConversionUtil {
+ /**
+* Convert the given Table to {@link DataSet}<{@link Row}>.
+*
+* @param sessionId the sessionId of {@link MLEnvironmentFactory}
+* @param table the Table to convert.
+* @return the converted DataSet.
+*/
+ public static DataSet fromTable(Long sessionId, Table table) {
+ return MLEnvironmentFactory
+ .get(sessionId)
+ .getBatchTableEnvironment()
+ .toDataSet(table, Row.class);
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified TableSchema.
+*
+* @param sessionId the sessionId of {@link MLEnvironmentFactory}
+* @param data the DataSet to convert.
+* @param schema the specified TableSchema.
+* @return the converted Table.
+*/
+ public static Table toTable(Long sessionId, DataSet data,
TableSchema schema) {
+ return toTable(sessionId, data, schema.getFieldNames(),
schema.getFieldTypes());
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified colNames and
colTypes.
+*
+* @param sessionId sessionId the sessionId of {@link
MLEnvironmentFactory}.
+* @param data the DataSet to convert.
+* @param colNames the specified colNames.
+* @param colTypes the specified colTypes. This variable is used only
when the
+* DataSet is produced by a function and Flink cannot
determine
+* automatically what the produced type is.
+* @return the converted Table.
+*/
+ public static Table toTable(Long sessionId, DataSet data,
String[] colNames, TypeInformation [] colTypes) {
+ return toTable(MLEnvironmentFactory.get(sessionId), data,
colNames, colTypes);
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified colNames.
+*
+* @param sessionId sessionId the sessionId of {@link
MLEnvironmentFactory}.
+* @param data the DataSet to convert.
+* @param colNames the specified colNames.
+* @return the converted Table.
+*/
+ public static Table toTable(Long sessionId, DataSet data,
String[] colNames) {
+ return toTable(MLEnvironmentFactory.get(sessionId), data,
colNames);
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified colNames and
colTypes.
+*
+* @param session the MLEnvironment using to convert DataSet to Table.
+* @param data the DataSet to convert.
+* @param colNames the specified colNames.
+* @param colTypes the specified colTypes. This variable is used only
when the
+* DataSet is produced by a function and Flink cannot
determine
+* automatically what the produced type is.
+* @return the converted Table.
+*/
+ public static Table toTable(MLEnvironment session, DataSet data,
[GitHub] [flink] walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add two utils for Table transformations
walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add
two utils for Table transformations
URL: https://github.com/apache/flink/pull/9373#discussion_r342374624
##
File path:
flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/common/utils/DataSetConversionUtil.java
##
@@ -0,0 +1,171 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.ml.common.utils;
+
+import org.apache.flink.api.common.functions.MapFunction;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.java.DataSet;
+import org.apache.flink.api.java.operators.SingleInputUdfOperator;
+import org.apache.flink.api.java.operators.TwoInputUdfOperator;
+import org.apache.flink.api.java.typeutils.RowTypeInfo;
+import org.apache.flink.ml.common.MLEnvironment;
+import org.apache.flink.ml.common.MLEnvironmentFactory;
+import org.apache.flink.table.api.Table;
+import org.apache.flink.table.api.TableSchema;
+import org.apache.flink.types.Row;
+
+/**
+ * Provide functions of conversions between DataSet and Table.
+ */
+public class DataSetConversionUtil {
+ /**
+* Convert the given Table to {@link DataSet}<{@link Row}>.
+*
+* @param sessionId the sessionId of {@link MLEnvironmentFactory}
+* @param table the Table to convert.
+* @return the converted DataSet.
+*/
+ public static DataSet fromTable(Long sessionId, Table table) {
+ return MLEnvironmentFactory
+ .get(sessionId)
+ .getBatchTableEnvironment()
+ .toDataSet(table, Row.class);
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified TableSchema.
+*
+* @param sessionId the sessionId of {@link MLEnvironmentFactory}
+* @param data the DataSet to convert.
+* @param schema the specified TableSchema.
+* @return the converted Table.
+*/
+ public static Table toTable(Long sessionId, DataSet data,
TableSchema schema) {
Review comment:
This API seems to be not tested.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add two utils for Table transformations
walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add
two utils for Table transformations
URL: https://github.com/apache/flink/pull/9373#discussion_r342375974
##
File path:
flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/common/utils/DataSetConversionUtil.java
##
@@ -0,0 +1,171 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.ml.common.utils;
+
+import org.apache.flink.api.common.functions.MapFunction;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.java.DataSet;
+import org.apache.flink.api.java.operators.SingleInputUdfOperator;
+import org.apache.flink.api.java.operators.TwoInputUdfOperator;
+import org.apache.flink.api.java.typeutils.RowTypeInfo;
+import org.apache.flink.ml.common.MLEnvironment;
+import org.apache.flink.ml.common.MLEnvironmentFactory;
+import org.apache.flink.table.api.Table;
+import org.apache.flink.table.api.TableSchema;
+import org.apache.flink.types.Row;
+
+/**
+ * Provide functions of conversions between DataSet and Table.
+ */
+public class DataSetConversionUtil {
+ /**
+* Convert the given Table to {@link DataSet}<{@link Row}>.
+*
+* @param sessionId the sessionId of {@link MLEnvironmentFactory}
+* @param table the Table to convert.
+* @return the converted DataSet.
+*/
+ public static DataSet fromTable(Long sessionId, Table table) {
+ return MLEnvironmentFactory
+ .get(sessionId)
+ .getBatchTableEnvironment()
+ .toDataSet(table, Row.class);
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified TableSchema.
+*
+* @param sessionId the sessionId of {@link MLEnvironmentFactory}
+* @param data the DataSet to convert.
+* @param schema the specified TableSchema.
+* @return the converted Table.
+*/
+ public static Table toTable(Long sessionId, DataSet data,
TableSchema schema) {
+ return toTable(sessionId, data, schema.getFieldNames(),
schema.getFieldTypes());
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified colNames and
colTypes.
+*
+* @param sessionId sessionId the sessionId of {@link
MLEnvironmentFactory}.
+* @param data the DataSet to convert.
+* @param colNames the specified colNames.
+* @param colTypes the specified colTypes. This variable is used only
when the
+* DataSet is produced by a function and Flink cannot
determine
+* automatically what the produced type is.
+* @return the converted Table.
+*/
+ public static Table toTable(Long sessionId, DataSet data,
String[] colNames, TypeInformation [] colTypes) {
+ return toTable(MLEnvironmentFactory.get(sessionId), data,
colNames, colTypes);
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified colNames.
+*
+* @param sessionId sessionId the sessionId of {@link
MLEnvironmentFactory}.
+* @param data the DataSet to convert.
+* @param colNames the specified colNames.
+* @return the converted Table.
+*/
+ public static Table toTable(Long sessionId, DataSet data,
String[] colNames) {
+ return toTable(MLEnvironmentFactory.get(sessionId), data,
colNames);
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified colNames and
colTypes.
+*
+* @param session the MLEnvironment using to convert DataSet to Table.
+* @param data the DataSet to convert.
+* @param colNames the specified colNames.
+* @param colTypes the specified colTypes. This variable is used only
when the
+* DataSet is produced by a function and Flink cannot
determine
+* automatically what the produced type is.
+* @return the converted Table.
+*/
+ public static Table toTable(MLEnvironment session, DataSet data,
[GitHub] [flink] walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add two utils for Table transformations
walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add
two utils for Table transformations
URL: https://github.com/apache/flink/pull/9373#discussion_r340183677
##
File path:
flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/common/utils/RowTypeDataSet.java
##
@@ -0,0 +1,168 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.ml.common.utils;
+
+import org.apache.flink.api.common.functions.MapFunction;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.java.DataSet;
+import org.apache.flink.api.java.operators.SingleInputUdfOperator;
+import org.apache.flink.api.java.operators.TwoInputUdfOperator;
+import org.apache.flink.api.java.typeutils.RowTypeInfo;
+import org.apache.flink.ml.common.MLEnvironment;
+import org.apache.flink.ml.common.MLEnvironmentFactory;
+import org.apache.flink.table.api.Table;
+import org.apache.flink.table.api.TableSchema;
+import org.apache.flink.types.Row;
+
+/**
+ * Provide functions of conversions between DataSet and Table.
+ */
+public class RowTypeDataSet {
+ /**
+* Convert the given Table to {@link DataSet DataSet}.
+*
+* @param sessionId the sessionId of {@link MLEnvironmentFactory}
+* @param table the Table to convert.
+* @return the converted DataSet.
+*/
+ public static DataSet fromTable(Long sessionId, Table table) {
+ return
MLEnvironmentFactory.get(sessionId).getBatchTableEnvironment().toDataSet(table,
Row.class);
Review comment:
did it throw exception of line too long? this should be captured by
checkstyle though
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add two utils for Table transformations
walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add
two utils for Table transformations
URL: https://github.com/apache/flink/pull/9373#discussion_r340185697
##
File path:
flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/common/utils/RowTypeDataSet.java
##
@@ -0,0 +1,168 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.ml.common.utils;
+
+import org.apache.flink.api.common.functions.MapFunction;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.java.DataSet;
+import org.apache.flink.api.java.operators.SingleInputUdfOperator;
+import org.apache.flink.api.java.operators.TwoInputUdfOperator;
+import org.apache.flink.api.java.typeutils.RowTypeInfo;
+import org.apache.flink.ml.common.MLEnvironment;
+import org.apache.flink.ml.common.MLEnvironmentFactory;
+import org.apache.flink.table.api.Table;
+import org.apache.flink.table.api.TableSchema;
+import org.apache.flink.types.Row;
+
+/**
+ * Provide functions of conversions between DataSet and Table.
+ */
+public class RowTypeDataSet {
+ /**
+* Convert the given Table to {@link DataSet DataSet}.
Review comment:
```
{@link DataSet}<{@link Row}>
```
See: https://stackoverflow.com/a/9541824/11332462 ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add two utils for Table transformations
walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add
two utils for Table transformations
URL: https://github.com/apache/flink/pull/9373#discussion_r340193149
##
File path:
flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/common/utils/RowTypeDataStream.java
##
@@ -0,0 +1,157 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.ml.common.utils;
+
+import org.apache.flink.api.common.functions.MapFunction;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.java.typeutils.RowTypeInfo;
+import org.apache.flink.ml.common.MLEnvironment;
+import org.apache.flink.ml.common.MLEnvironmentFactory;
+import org.apache.flink.streaming.api.datastream.DataStream;
+import org.apache.flink.table.api.Table;
+import org.apache.flink.table.api.TableSchema;
+import org.apache.flink.types.Row;
+
+/**
+ * Provide functions of conversions between DataStream and Table.
+ */
+public class RowTypeDataStream {
+ /**
+* Convert the given Table to {@link DataStream DataStream}.
+*
+* @param sessionId the sessionId of {@link MLEnvironmentFactory}
+* @param table the Table to convert.
+* @return the converted DataStream.
+*/
+ public static DataStream fromTable(Long sessionId, Table table) {
Review comment:
nit: If we rename these two APIs to `convertToDataStream` &
`convertToDataSet` we can probably combine the two files. since `MLEnvironment`
encapsulates both Batch and Stream envs. it is also consistent IMO.
I am fine with keeping two files and separate these APIs as well. maybe some
other folks can provide some feedbacks on this.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add two utils for Table transformations
walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add
two utils for Table transformations
URL: https://github.com/apache/flink/pull/9373#discussion_r340185184
##
File path:
flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/common/utils/RowTypeDataSet.java
##
@@ -0,0 +1,168 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.ml.common.utils;
+
+import org.apache.flink.api.common.functions.MapFunction;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.java.DataSet;
+import org.apache.flink.api.java.operators.SingleInputUdfOperator;
+import org.apache.flink.api.java.operators.TwoInputUdfOperator;
+import org.apache.flink.api.java.typeutils.RowTypeInfo;
+import org.apache.flink.ml.common.MLEnvironment;
+import org.apache.flink.ml.common.MLEnvironmentFactory;
+import org.apache.flink.table.api.Table;
+import org.apache.flink.table.api.TableSchema;
+import org.apache.flink.types.Row;
+
+/**
+ * Provide functions of conversions between DataSet and Table.
+ */
+public class RowTypeDataSet {
Review comment:
the naming conversion for these two class is a bit confusing.
My best suggestion may be: `DataSetConversionUtil` &
`DataStreamConversionUtil` ?
The rationale is: given the fact that the `flink-ml` package dominantly
works on the Table API. this would be more of a conversion utility?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add two utils for Table transformations
walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add
two utils for Table transformations
URL: https://github.com/apache/flink/pull/9373#discussion_r340189365
##
File path:
flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/common/utils/RowTypeDataSet.java
##
@@ -0,0 +1,168 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.ml.common.utils;
+
+import org.apache.flink.api.common.functions.MapFunction;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.java.DataSet;
+import org.apache.flink.api.java.operators.SingleInputUdfOperator;
+import org.apache.flink.api.java.operators.TwoInputUdfOperator;
+import org.apache.flink.api.java.typeutils.RowTypeInfo;
+import org.apache.flink.ml.common.MLEnvironment;
+import org.apache.flink.ml.common.MLEnvironmentFactory;
+import org.apache.flink.table.api.Table;
+import org.apache.flink.table.api.TableSchema;
+import org.apache.flink.types.Row;
+
+/**
+ * Provide functions of conversions between DataSet and Table.
+ */
+public class RowTypeDataSet {
+ /**
+* Convert the given Table to {@link DataSet DataSet}.
+*
+* @param sessionId the sessionId of {@link MLEnvironmentFactory}
+* @param table the Table to convert.
+* @return the converted DataSet.
+*/
+ public static DataSet fromTable(Long sessionId, Table table) {
+ return
MLEnvironmentFactory.get(sessionId).getBatchTableEnvironment().toDataSet(table,
Row.class);
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified TableSchema.
+*
+* @param sessionId the sessionId of {@link MLEnvironmentFactory}
+* @param data the DataSet to convert.
+* @param schema the specified TableSchema.
+* @return the converted Table.
+*/
+ public static Table toTable(Long sessionId, DataSet data,
TableSchema schema) {
+ return toTable(sessionId, data, schema.getFieldNames(),
schema.getFieldTypes());
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified colNames and
colTypes.
+*
+* @param sessionId sessionId the sessionId of {@link
MLEnvironmentFactory}.
+* @param data the DataSet to convert.
+* @param colNames the specified colNames.
+* @param colTypes the specified colTypes. This variable is used only
when the
+* DataSet is produced by a function and Flink cannot
determine
+* automatically what the produced type is.
+* @return the converted Table.
+*/
+ public static Table toTable(Long sessionId, DataSet data,
String[] colNames, TypeInformation [] colTypes) {
Review comment:
nit: maybe this is a good time to clarify what's the longer term plan to
comply with
[FLIP-65](https://cwiki.apache.org/confluence/display/FLINK/FLIP-65%3A+New+type+inference+for+Table+API+UDFs)
IMO, we just need to support `TableSchema` as the main entry point since
FlinkML is majorly on table API. supporting TypeInformation means we need to
later support `DataType` and this seems to be a hell lot of API to maintain.
This also hide out the underlying type objects from user.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add two utils for Table transformations
walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add
two utils for Table transformations
URL: https://github.com/apache/flink/pull/9373#discussion_r340188110
##
File path:
flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/common/utils/RowTypeDataSet.java
##
@@ -0,0 +1,168 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.ml.common.utils;
+
+import org.apache.flink.api.common.functions.MapFunction;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.java.DataSet;
+import org.apache.flink.api.java.operators.SingleInputUdfOperator;
+import org.apache.flink.api.java.operators.TwoInputUdfOperator;
+import org.apache.flink.api.java.typeutils.RowTypeInfo;
+import org.apache.flink.ml.common.MLEnvironment;
+import org.apache.flink.ml.common.MLEnvironmentFactory;
+import org.apache.flink.table.api.Table;
+import org.apache.flink.table.api.TableSchema;
+import org.apache.flink.types.Row;
+
+/**
+ * Provide functions of conversions between DataSet and Table.
+ */
+public class RowTypeDataSet {
+ /**
+* Convert the given Table to {@link DataSet DataSet}.
+*
+* @param sessionId the sessionId of {@link MLEnvironmentFactory}
+* @param table the Table to convert.
+* @return the converted DataSet.
+*/
+ public static DataSet fromTable(Long sessionId, Table table) {
+ return
MLEnvironmentFactory.get(sessionId).getBatchTableEnvironment().toDataSet(table,
Row.class);
+ }
+
+ /**
+* Convert the given DataSet into a Table with specified TableSchema.
+*
+* @param sessionId the sessionId of {@link MLEnvironmentFactory}
+* @param data the DataSet to convert.
+* @param schema the specified TableSchema.
+* @return the converted Table.
+*/
+ public static Table toTable(Long sessionId, DataSet data,
TableSchema schema) {
+ return toTable(sessionId, data, schema.getFieldNames(),
schema.getFieldTypes());
Review comment:
`TableSchema`.`getFieldTypes()` is deprecated
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
