[GitHub] [flink] wuchong commented on a change in pull request #17842: [FLINK-24966] [docs] Fix spelling errors in the project
wuchong commented on a change in pull request #17842:
URL: https://github.com/apache/flink/pull/17842#discussion_r756141514
##
File path:
flink-java/src/test/java/org/apache/flink/api/java/utils/OptionsTest.java
##
@@ -54,16 +54,6 @@ public void testChoicesWithValidDefaultValue() {
Assert.assertEquals(option.getDefaultValue(), "a");
}
-@Test
-public void testChoicesWithInvalidDefautlValue() throws
RequiredParametersException {
Review comment:
I would suggest to change the method name to
`testChoicesWithInvalidDefaultValue2` and put it after
`testChoicesWithInvalidDefaultValue`.
`expectedException` can't be used in a test method twice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #17842: [FLINK-24966] [docs] Fix spelling errors in the project
wuchong commented on a change in pull request #17842:
URL: https://github.com/apache/flink/pull/17842#discussion_r755911795
##
File path:
flink-java/src/test/java/org/apache/flink/api/java/utils/OptionsTest.java
##
@@ -54,16 +54,6 @@ public void testChoicesWithValidDefaultValue() {
Assert.assertEquals(option.getDefaultValue(), "a");
}
-@Test
-public void testChoicesWithInvalidDefautlValue() throws
RequiredParametersException {
Review comment:
But the test code is different from
`testChoicesWithInvalidDefaultValue`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #17842: [FLINK-24966] [docs] Fix spelling errors in the project
wuchong commented on a change in pull request #17842:
URL: https://github.com/apache/flink/pull/17842#discussion_r754929377
##
File path:
flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/DataStream.scala
##
@@ -141,7 +141,7 @@ class DataStream[T](stream: JavaStream[T]) {
case ds: SingleOutputStreamOperator[T] =>
ds.setMaxParallelism(maxParallelism)
case _ =>
throw new UnsupportedOperationException("Operator " + stream + "
cannot set the maximum" +
- "paralllelism")
+ "parallelism")
Review comment:
```suggestion
" parallelism")
```
Add a space.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #17842: [FLINK-24966] [docs] Fix spelling errors in the project
wuchong commented on a change in pull request #17842:
URL: https://github.com/apache/flink/pull/17842#discussion_r754787598
##
File path: flink-end-to-end-tests/flink-tpcds-test/tpcds-tool/query/query44.sql
##
@@ -1,5 +1,5 @@
-- start query 1 in stream 0 using template
../query_templates_qualified/query44.tpl
-select asceding.rnk, i1.i_product_name best_performing, i2.i_product_name
worst_performing
+select ascending.rnk, i1.i_product_name best_performing, i2.i_product_name
worst_performing
Review comment:
The origin TP-CDS query using `asceding`, so I would prefer not changing
this file.
##
File path:
flink-core/src/test/java/org/apache/flink/core/fs/EntropyInjectorTest.java
##
@@ -169,7 +169,7 @@ public void testWithSafetyNet() throws Exception {
}
@Test
-public void testClassLoaderFixingFsWithSafeyNet() throws Exception {
+public void testClassLoaderFixingFsWithSafeNet() throws Exception {
Review comment:
```suggestion
public void testClassLoaderFixingFsWithSafetyNet() throws Exception {
```
##
File path:
flink-formats/flink-avro/src/test/java/org/apache/flink/formats/avro/EncoderDecoderTest.java
##
@@ -58,7 +58,7 @@
public class EncoderDecoderTest {
@Test
-public void testComplexStringsDirecty() {
+public void testComplexStringsDirect() {
Review comment:
```suggestion
public void testComplexStringsDirectly() {
```
##
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/StreamTaskSourceInput.java
##
@@ -106,7 +106,7 @@ public int getNumberOfInputChannels() {
* from a network input. So that we can checkpoint state of the source and
all of the other
* operators at the same time.
*
- * Also we are choosing to block the source, as a best effort
optimisation as: - either there
+ * Also we are choosing to block the source, as a best effort
Optimization as: - either there
Review comment:
```suggestion
* Also we are choosing to block the source, as a best effort
optimization as: - either there
```
##
File path:
flink-core/src/test/java/org/apache/flink/core/fs/EntropyInjectorTest.java
##
@@ -195,7 +195,7 @@ public void testClassLoaderFixingFsWithSafeyNet() throws
Exception {
}
@Test
-public void testClassLoaderFixingFsWithoutSafeyNet() throws Exception {
+public void testClassLoaderFixingFsWithoutSafeNet() throws Exception {
Review comment:
```suggestion
public void testClassLoaderFixingFsWithoutSafetyNet() throws Exception {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
