wuchong commented on a change in pull request #8909:
[FLINK-13004][table-runtime-blink] Correct the logic of needToCleanupState in
KeyedProcessFunctionWithCleanupState
URL: https://github.com/apache/flink/pull/8909#discussion_r298108636
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/over/AbstractRowTimeUnboundedPrecedingOver.java
##########
@@ -157,7 +157,7 @@ public void onTimer(
if (needToCleanupState(timestamp)) {
// we check whether there are still records
which have not been processed yet
- boolean noRecordsToProcess =
!inputState.contains(timestamp);
+ boolean noRecordsToProcess =
!inputState.keys().iterator().hasNext();
Review comment:
good catch!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
