[GitHub] [flink] wuchong commented on pull request #11906: [FLINK-17356][jdbc][postgres] Support PK and Unique constraints

2020-05-20 Thread GitBox


wuchong commented on pull request #11906:
URL: https://github.com/apache/flink/pull/11906#issuecomment-631504885


   Passed. 
   Merging...



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] wuchong commented on pull request #11906: [FLINK-17356][jdbc][postgres] Support PK and Unique constraints

2020-05-19 Thread GitBox


wuchong commented on pull request #11906:
URL: https://github.com/apache/flink/pull/11906#issuecomment-631225241


   Thanks @fpompermaier , it looks good to me in general. I added an IT case to 
verify group by query can be inserted into a primary keyed postgres catalog 
table (this is the purpose of FLINK-17762). Besides, I slightly updated the 
`getPrimaryKey` to make it return an optional constraint instead of nullable 
constraint. I hope that's ok.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org