[GitHub] [flink] wuchong commented on pull request #12320: [FLINK-17887][table][connector] Improve interface of ScanFormatFactory and SinkFormatFactory

2020-05-26 Thread GitBox 


wuchong commented on pull request #12320:
URL: https://github.com/apache/flink/pull/12320#issuecomment-634421914


   Hi @twalthr , I can see the benefit to have a hierarchy in the format 
interfaces.  What do you think about to use the first proposal in our offline 
discussion? That `DecodingFormat#createRuntimeDecoder()` and 
`EncodingFormat#createRuntimeEncoder()`. I don't have a clear idea how to give 
a suitable method name for `SourceFormat#createXxxx`. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] wuchong commented on pull request #12320: [FLINK-17887][table][connector] Improve interface of ScanFormatFactory and SinkFormatFactory

2020-05-25 Thread GitBox 


wuchong commented on pull request #12320:
URL: https://github.com/apache/flink/pull/12320#issuecomment-633558842


   When I writing the code, I have a feeling that maybe `DeserializationFormat` 
is a better name than `DeserializationSchemaProvider` , because it is created 
from `DeserializationFormatFactory` and is more intuitive in the 
`FactoryUtil#discoverXxxxFormat`. But I’m not sure what’s your opinion here 
@twalthr @KurtYoung , as we’re swinging in the new names again…



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org