wuchong edited a comment on issue #10001: [FLINK-14535][table-planner-blink] Fix distinct key type for DecimalT… URL: https://github.com/apache/flink/pull/10001#issuecomment-546767439 Hi @docete , thanks for the contribution. The change looks good to me. I think we can improve the tests a bit more. Could you add an integration test which tests count distinct on all types? So that, we can merge `testTimeDistinct` , `testDateDistinct`, `testTimestampDistinct`,`testCountDistinct` into one. And we should add a same test in `SplitAggregateITCase`.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
