[GitHub] [flink] xintongsong commented on issue #10829: [FLINK-14853][docs] Use higher granularity units in generated docs for Duration & MemorySize if possible
xintongsong commented on issue #10829: [FLINK-14853][docs] Use higher granularity units in generated docs for Duration & MemorySize if possible URL: https://github.com/apache/flink/pull/10829#issuecomment-574548126 @dawidwys Thanks for asking. What @tillrohrmann said sounds good to me. My only concern was that, as @tillrohrmann mentioned, it is more difficult to make sure always log MemorySize with some method other than `toString`. If we consider the approximate value as a special format that one should explicitly consent to, then it makes sense to me and I do not have other objections. +1 for merging this PR as MemorySize prints exact values in `toString`. I'll adjust mine #10785. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] xintongsong commented on issue #10829: [FLINK-14853][docs] Use higher granularity units in generated docs for Duration & MemorySize if possible
xintongsong commented on issue #10829: [FLINK-14853][docs] Use higher granularity units in generated docs for Duration & MemorySize if possible URL: https://github.com/apache/flink/pull/10829#issuecomment-574142242 Thank you @dawidwys, It also sounds good to me that to print only the exact value for the docs, while also keep the approximate for the logs. Let's wait for @azagrebin and @tillrohrmann 's feedback. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] xintongsong commented on issue #10829: [FLINK-14853][docs] Use higher granularity units in generated docs for Duration & MemorySize if possible
xintongsong commented on issue #10829: [FLINK-14853][docs] Use higher granularity units in generated docs for Duration & MemorySize if possible URL: https://github.com/apache/flink/pull/10829#issuecomment-573274699 Thanks for pointing me to this, @zentol. Hi @dawidwys, thanks for the PR. I agree it would be nice to have higher granularity unit in the docs. However, `MemorySize#toString` does not only affect the docs, but also logs. There are cases that memory sizes are derived from a total size and a fraction (e.g. managed memory). In those cases, a memory size could be large but not integer with high granularity units. Therefore, I think it would make sense to print both the exact bytes for accuracy and the coarse high granularity value for readability (as in #10785). WDYT? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
