[GitHub] [flink] xintongsong commented on pull request #14591: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes

2021-01-28 Thread GitBox


xintongsong commented on pull request #14591:
URL: https://github.com/apache/flink/pull/14591#issuecomment-769532716


   @blublinsky 
   
   By **explain in the configuration option description**, I don't mean to 
explain as comments in this GitHub Pull Request.
   
   In the file `KubernetesConfigOptions.java`, you added a `ConfigOption 
JOB_MANAGER_OWNER_REFERENCE`. This is the **configuration option**. When 
building this configuration option, there is a `withDescription()`, that sets 
the **description** for this configuration option. This description will be 
used for generating documents to help users understand how to use this 
configuration option.
   
   So what I meant is that we should explain the two questions in this 
description.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] xintongsong commented on pull request #14591: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes

2021-01-27 Thread GitBox


xintongsong commented on pull request #14591:
URL: https://github.com/apache/flink/pull/14591#issuecomment-768770142


   @blublinsky,
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org