[GitHub] [flink] yangyichao-mango commented on pull request #12196: [FLINK-17353][docs] Fix Broken links in Flink docs master

2020-05-18 Thread GitBox


yangyichao-mango commented on pull request #12196:
URL: https://github.com/apache/flink/pull/12196#issuecomment-630550918


   That is the result of check_links.sh.
   找到 1 个死链接。
   
   http://localhost:4000/zh/ops/memory/mem_detail.html
   
   When I try to fix http://localhost:4000/zh/ops/memory/mem_detail.html, I'm 
blocked by three mds that is not be updated.
   
   **ops/memory/mem_setup_tm.md**
   **ops/memory/mem_trouble.md**
   **ops/memory/mem_migration.md**
   
   I think we should create a new jira issue to update those mds. When this 
issue is done, I can fix this broken link 
(http://localhost:4000/zh/ops/memory/mem_detail.html).
   
   cc @wuchong 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] yangyichao-mango commented on pull request #12196: [FLINK-17353][docs] Fix Broken links in Flink docs master

2020-05-18 Thread GitBox


yangyichao-mango commented on pull request #12196:
URL: https://github.com/apache/flink/pull/12196#issuecomment-630192127


   @klion26 That is the result of spider.log
   Find 3 Broken links.
   
   http://localhost:4000/ops/memory/mem_setup_jm.html
   http://localhost:4000/zh/ops/memory/mem_detail.html
   http://localhost:4000/zh/dev/user_defined_functions.html
   
   But All of this three broken links don't belong to 
[[FLINK-17353](https://issues.apache.org/jira/browse/FLINK-17353)].
   Do i need to Fix those broken links?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] yangyichao-mango commented on pull request #12196: [FLINK-17353][docs] Fix Broken links in Flink docs master

2020-05-17 Thread GitBox


yangyichao-mango commented on pull request #12196:
URL: https://github.com/apache/flink/pull/12196#issuecomment-629932611


   That is the result after execute sh docs/check_links.sh. Thx for review. 
@klion26 
   
![image](https://user-images.githubusercontent.com/29545877/82173270-30bd0d80-98ff-11ea-9721-22e06d4b6211.png)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] yangyichao-mango commented on pull request #12196: [FLINK-17353][docs] Fix Broken links in Flink docs master

2020-05-17 Thread GitBox


yangyichao-mango commented on pull request #12196:
URL: https://github.com/apache/flink/pull/12196#issuecomment-629932483


   > @yangyichao-mango thanks for your contribution. could you please share the 
result after execute `sh docs/check_links.sh` here (you have to execute `sh 
docs/build_docs.sh -p ` before execute the check_links script)
   
   @klion26 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] yangyichao-mango commented on pull request #12196: [FLINK-17353][docs] Fix Broken links in Flink docs master

2020-05-17 Thread GitBox


yangyichao-mango commented on pull request #12196:
URL: https://github.com/apache/flink/pull/12196#issuecomment-629932386


   > @yangyichao-mango thanks for your contribution. could you please share the 
result after execute `sh docs/check_links.sh` here (you have to execute `sh 
docs/build_docs.sh -p ` before execute the check_links script)
   
   
![image](https://user-images.githubusercontent.com/29545877/82173191-f18ebc80-98fe-11ea-8972-0173a641996f.png)
   That is the result after execute sh docs/check_links.sh



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] yangyichao-mango commented on pull request #12196: [FLINK-17353][docs] Fix Broken links in Flink docs master

2020-05-17 Thread GitBox


yangyichao-mango commented on pull request #12196:
URL: https://github.com/apache/flink/pull/12196#issuecomment-629932115


   
![image](https://user-images.githubusercontent.com/29545877/82173155-dd4abf80-98fe-11ea-8f36-5f10f6f10781.png)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] yangyichao-mango commented on pull request #12196: [FLINK-17353][docs] Fix Broken links in Flink docs master

2020-05-17 Thread GitBox


yangyichao-mango commented on pull request #12196:
URL: https://github.com/apache/flink/pull/12196#issuecomment-629755819


   cc @wuchong 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org