[GitHub] [flink] yiduwangkai commented on issue #9164: [FLINK-12894][doc][Chinese-translation]add Chinese documentation of how to configure and use catalogs in SQL CLI

2019-08-13 Thread GitBox
yiduwangkai commented on issue #9164: 
[FLINK-12894][doc][Chinese-translation]add Chinese documentation of how to 
configure and use catalogs in SQL CLI
URL: https://github.com/apache/flink/pull/9164#issuecomment-520886143
 
 
   i want to close this pr, merge [apache/flink] [FLINK-13086]add Chinese
   documentation for catalogs (#9163)
   and [apache/flink] [FLINK-12894]add Chinese documentation of how to
   configure and use catalogs in SQL CLI (#9164) together and submit a new
   one, do you agree
   
   Bowen L  于2019年8月13日周二 上午2:36写道:
   
   > Hi @yiduwangkai  , can you rebase this PR?
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > 
,
   > or mute the thread
   > 

   > .
   >
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] yiduwangkai commented on issue #9164: [FLINK-12894][doc][Chinese-translation]add Chinese documentation of how to configure and use catalogs in SQL CLI

2019-08-12 Thread GitBox
yiduwangkai commented on issue #9164: 
[FLINK-12894][doc][Chinese-translation]add Chinese documentation of how to 
configure and use catalogs in SQL CLI
URL: https://github.com/apache/flink/pull/9164#issuecomment-520654288
 
 
   > Hi @yiduwangkai , can you rebase this PR?
   
   Ok


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] yiduwangkai commented on issue #9164: [FLINK-12894][doc][Chinese-translation]add Chinese documentation of how to configure and use catalogs in SQL CLI

2019-07-21 Thread GitBox
yiduwangkai commented on issue #9164: 
[FLINK-12894][doc][Chinese-translation]add Chinese documentation of how to 
configure and use catalogs in SQL CLI
URL: https://github.com/apache/flink/pull/9164#issuecomment-513566443
 
 
   Why is there a new merge commit extra information, because I use the pull
   command to pull the latest code of the upstream branch, this record will be
   generated if the local branch lags behind the upstream branch
   
   kai wang  于2019年7月21日周日 下午11:28写道:
   
   > yes i used rebase at first, But when I execute this command, when I push,
   > git asks for pull, maybe it is improper operation before, causing the
   > situation to be merged when the pull occurs, but please be assured that no
   > other files have been changed. thx
   >
   > Jark Wu  于2019年7月21日周日 下午10:19写道:
   >
   >> @yiduwangkai  , please rebase your
   >> commit on the latest master and do not use "merge".
   >>
   >> —
   >> You are receiving this because you were mentioned.
   >> Reply to this email directly, view it on GitHub
   >> 
,
   >> or mute the thread
   >> 

   >> .
   >>
   >
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] yiduwangkai commented on issue #9164: [FLINK-12894][doc][Chinese-translation]add Chinese documentation of how to configure and use catalogs in SQL CLI

2019-07-21 Thread GitBox
yiduwangkai commented on issue #9164: 
[FLINK-12894][doc][Chinese-translation]add Chinese documentation of how to 
configure and use catalogs in SQL CLI
URL: https://github.com/apache/flink/pull/9164#issuecomment-513563999
 
 
   > @yiduwangkai , please rebase your commit on the latest master and do not 
use "merge".
   
   yes i used rebase at first, But when I execute this command, when I push, 
git asks for pull, maybe it is improper operation before, causing the situation 
to be merged when the pull occurs, but please be assured that no other files 
have been changed. thx


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] yiduwangkai commented on issue #9164: [FLINK-12894][doc][Chinese-translation]add Chinese documentation of how to configure and use catalogs in SQL CLI

2019-07-21 Thread GitBox
yiduwangkai commented on issue #9164: 
[FLINK-12894][doc][Chinese-translation]add Chinese documentation of how to 
configure and use catalogs in SQL CLI
URL: https://github.com/apache/flink/pull/9164#issuecomment-513563955
 
 
   yes i used rebase at first, But when I execute this command, when I push,
   git asks for pull, maybe it is improper operation before, causing the
   situation to be merged when the pull occurs, but please be assured that no
   other files have been changed. thx
   
   Jark Wu  于2019年7月21日周日 下午10:19写道:
   
   > @yiduwangkai  , please rebase your commit
   > on the latest master and do not use "merge".
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > 
,
   > or mute the thread
   > 

   > .
   >
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] yiduwangkai commented on issue #9164: [FLINK-12894][doc][Chinese-translation]add Chinese documentation of how to configure and use catalogs in SQL CLI

2019-07-21 Thread GitBox
yiduwangkai commented on issue #9164: 
[FLINK-12894][doc][Chinese-translation]add Chinese documentation of how to 
configure and use catalogs in SQL CLI
URL: https://github.com/apache/flink/pull/9164#issuecomment-513557629
 
 
   i have updated @bowenli86


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services