[GitHub] [flink] zentol commented on a change in pull request #11626: [FLINK-16961] Bump Netty 4.X to 4.1.44
zentol commented on a change in pull request #11626: [FLINK-16961] Bump Netty 4.X to 4.1.44 URL: https://github.com/apache/flink/pull/11626#discussion_r404652193 ## File path: flink-connectors/flink-connector-cassandra/src/main/resources/META-INF/NOTICE ## @@ -9,8 +9,8 @@ This project bundles the following dependencies under the Apache Software Licens - com.datastax.cassandra:cassandra-driver-core:3.0.0 - com.datastax.cassandra:cassandra-driver-mapping:3.0.0 - com.google.guava:guava:18.0 -- io.netty:netty-handler:4.0.33.Final -- io.netty:netty-buffer:4.0.33.Final -- io.netty:netty-common:4.0.33.Final -- io.netty:netty-transport:4.0.33.Final -- io.netty:netty-codec:4.0.33.Final +- io.netty:netty-handler:4.1.44.Final +- io.netty:netty-buffer:4.1.44.Final +- io.netty:netty-common:4.1.44.Final +- io.netty:netty-transport:4.1.44.Final +- io.netty:netty-codec:4.1.44.Final Review comment: ah, i see it now. I must've checked on the wrong branch. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #11626: [FLINK-16961] Bump Netty 4.X to 4.1.44
zentol commented on a change in pull request #11626: [FLINK-16961] Bump Netty
4.X to 4.1.44
URL: https://github.com/apache/flink/pull/11626#discussion_r404635655
##
File path: flink-connectors/flink-connector-hive/pom.xml
##
@@ -934,6 +934,42 @@ under the License.
3.1.1
+
+
+ org.apache.hive
+ hive-metastore
+ ${hive.version}
+ provided
+
+
+
+
io.netty
+
netty-buffer
+
+
+
+
io.netty
+
netty-common
+
+
+
+
+
+ io.netty
+ netty-buffer
+ 4.1.44.Final
+ provided
+
+
+
+
+ io.netty
+ netty-common
+ 4.1.44.Final
+ provided
+
+
Review comment:
This dependencies block is in the `hive-3.1.1` profile, so it is kinda
important ;)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #11626: [FLINK-16961] Bump Netty 4.X to 4.1.44
zentol commented on a change in pull request #11626: [FLINK-16961] Bump Netty 4.X to 4.1.44 URL: https://github.com/apache/flink/pull/11626#discussion_r404196927 ## File path: flink-connectors/flink-connector-cassandra/src/main/resources/META-INF/NOTICE ## @@ -9,8 +9,8 @@ This project bundles the following dependencies under the Apache Software Licens - com.datastax.cassandra:cassandra-driver-core:3.0.0 - com.datastax.cassandra:cassandra-driver-mapping:3.0.0 - com.google.guava:guava:18.0 -- io.netty:netty-handler:4.0.33.Final -- io.netty:netty-buffer:4.0.33.Final -- io.netty:netty-common:4.0.33.Final -- io.netty:netty-transport:4.0.33.Final -- io.netty:netty-codec:4.0.33.Final +- io.netty:netty-handler:4.1.44.Final +- io.netty:netty-buffer:4.1.44.Final +- io.netty:netty-common:4.1.44.Final +- io.netty:netty-transport:4.1.44.Final +- io.netty:netty-codec:4.1.44.Final Review comment: I don't see `netty-resolver` in the dependency or shade-plugin output. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #11626: [FLINK-16961] Bump Netty 4.X to 4.1.44
zentol commented on a change in pull request #11626: [FLINK-16961] Bump Netty
4.X to 4.1.44
URL: https://github.com/apache/flink/pull/11626#discussion_r404197167
##
File path: flink-connectors/flink-connector-elasticsearch5/pom.xml
##
@@ -82,6 +82,55 @@ under the License.
${elasticsearch.version}
+
+
+ io.netty
+ netty-buffer
+ 4.1.44.Final
Review comment:
Smallest required jump.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #11626: [FLINK-16961] Bump Netty 4.X to 4.1.44
zentol commented on a change in pull request #11626: [FLINK-16961] Bump Netty 4.X to 4.1.44 URL: https://github.com/apache/flink/pull/11626#discussion_r404194416 ## File path: flink-python/src/main/resources/META-INF/NOTICE ## @@ -20,13 +20,13 @@ This project bundles the following dependencies under the Apache Software Licens - io.grpc:grpc-protobuf:1.21.0 - io.grpc:grpc-stub:1.21.0 - io.grpc:grpc-testing:1.21.0 -- io.netty:netty-buffer:4.1.27.Final +- io.netty:netty-buffer:4.1.44.Final - io.netty:netty-buffer:4.1.34.Final - io.netty:netty-codec:4.1.34.Final - io.netty:netty-codec-http:4.1.34.Final - io.netty:netty-codec-http2:4.1.34.Final - io.netty:netty-codec-socks:4.1.34.Final -- io.netty:netty-common:4.1.27.Final +- io.netty:netty-common:4.1.44.Final - io.netty:netty-common:4.1.34.Final - io.netty:netty-handler:4.1.34.Final - io.netty:netty-handler-proxy:4.1.34.Final Review comment: I did ignore them tho and had to do some research first, good job pointing them out. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #11626: [FLINK-16961] Bump Netty 4.X to 4.1.44
zentol commented on a change in pull request #11626: [FLINK-16961] Bump Netty 4.X to 4.1.44 URL: https://github.com/apache/flink/pull/11626#discussion_r404193632 ## File path: flink-python/src/main/resources/META-INF/NOTICE ## @@ -20,13 +20,13 @@ This project bundles the following dependencies under the Apache Software Licens - io.grpc:grpc-protobuf:1.21.0 - io.grpc:grpc-stub:1.21.0 - io.grpc:grpc-testing:1.21.0 -- io.netty:netty-buffer:4.1.27.Final +- io.netty:netty-buffer:4.1.44.Final - io.netty:netty-buffer:4.1.34.Final - io.netty:netty-codec:4.1.34.Final - io.netty:netty-codec-http:4.1.34.Final - io.netty:netty-codec-http2:4.1.34.Final - io.netty:netty-codec-socks:4.1.34.Final -- io.netty:netty-common:4.1.27.Final +- io.netty:netty-common:4.1.44.Final - io.netty:netty-common:4.1.34.Final - io.netty:netty-handler:4.1.34.Final - io.netty:netty-handler-proxy:4.1.34.Final Review comment: These are bundled in `beam-vendor-grpc-1_21_0`, and I have no idea how/whether we can update these. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #11626: [FLINK-16961] Bump Netty 4.X to 4.1.44
zentol commented on a change in pull request #11626: [FLINK-16961] Bump Netty
4.X to 4.1.44
URL: https://github.com/apache/flink/pull/11626#discussion_r404170996
##
File path: flink-connectors/flink-connector-hive/pom.xml
##
@@ -934,6 +934,42 @@ under the License.
3.1.1
+
+
+ org.apache.hive
+ hive-metastore
+ ${hive.version}
+ provided
+
+
+
+
io.netty
+
netty-buffer
+
+
+
+
io.netty
+
netty-common
+
+
+
+
+
+ io.netty
+ netty-buffer
+ 4.1.44.Final
+ provided
+
+
+
+
+ io.netty
+ netty-common
+ 4.1.44.Final
+ provided
+
+
Review comment:
did you activate the `hive-3.1.1` profile?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #11626: [FLINK-16961] Bump Netty 4.X to 4.1.44
zentol commented on a change in pull request #11626: [FLINK-16961] Bump Netty
4.X to 4.1.44
URL: https://github.com/apache/flink/pull/11626#discussion_r404170706
##
File path: flink-connectors/flink-connector-hive/pom.xml
##
@@ -934,6 +934,42 @@ under the License.
3.1.1
+
+
+ org.apache.hive
+ hive-metastore
+ ${hive.version}
+ provided
+
+
+
+
io.netty
+
netty-buffer
+
+
+
+
io.netty
+
netty-common
+
+
Review comment:
the dependency convergence complains because we did not explicitly handle
the mismatch.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
