[GitHub] [flink] zhuzhurk commented on a change in pull request #8233: [FLINK-12227] [runtime] introduce SchedulingStrategy interface
zhuzhurk commented on a change in pull request #8233: [FLINK-12227] [runtime]
introduce SchedulingStrategy interface
URL: https://github.com/apache/flink/pull/8233#discussion_r281001358
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/ExecutionVertexDeploymentOption.java
##
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.scheduler;
+
+import org.apache.flink.runtime.scheduler.strategy.ExecutionVertexID;
+
+/**
+ * Component that stores the task need to be scheduled and the option for
deployment.
+ */
+public class ExecutionVertexDeploymentOption {
+
+ private final ExecutionVertexID executionVertexId;
+
+ private final DeploymentOption deploymentOption;
+
+ public ExecutionVertexDeploymentOption(ExecutionVertexID
executionVertexId, DeploymentOption deploymentOption) {
Review comment:
Sorry I made a mistake here. I was bit confused of DeploymentOption and
ExecutionVertexDeploymentOption due to the similar name. Now I understand they
actually are different components. ExecutionVertexDeploymentOption is a
deployment descriptor and the DeploymentOption is a wrapper of the options.
Just wonder whether we can have different name patterns for them, like
ExecutionVertexDeploymentDescriptor and DeploymentOption?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhuzhurk commented on a change in pull request #8233: [FLINK-12227] [runtime] introduce SchedulingStrategy interface
zhuzhurk commented on a change in pull request #8233: [FLINK-12227] [runtime]
introduce SchedulingStrategy interface
URL: https://github.com/apache/flink/pull/8233#discussion_r279176101
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/ExecutionVertexDeploymentOption.java
##
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.scheduler;
+
+import org.apache.flink.runtime.scheduler.strategy.ExecutionVertexID;
+
+/**
+ * Component that stores the task need to be scheduled and the option for
deployment.
+ */
+public class ExecutionVertexDeploymentOption {
+
+ private final ExecutionVertexID executionVertexId;
+
+ private final DeploymentOption deploymentOption;
+
+ public ExecutionVertexDeploymentOption(ExecutionVertexID
executionVertexId, DeploymentOption deploymentOption) {
Review comment:
Currently we only have one kind of DeploymentOption
(ExecutionVertexDeploymentOption) and the SchedulingStrategy is bind to
ExecutionVertexID as well. Is it necessary to have a DeploymentOption?
B.T.W. If it is necessary, why using composition here rather than
inheritance?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhuzhurk commented on a change in pull request #8233: [FLINK-12227] [runtime] introduce SchedulingStrategy interface
zhuzhurk commented on a change in pull request #8233: [FLINK-12227] [runtime]
introduce SchedulingStrategy interface
URL: https://github.com/apache/flink/pull/8233#discussion_r279176271
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/strategy/SchedulingResultPartition.java
##
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.scheduler.strategy;
+
+import org.apache.flink.runtime.executiongraph.IntermediateResultPartition;
+import org.apache.flink.runtime.io.network.partition.ResultPartitionType;
+import org.apache.flink.runtime.jobgraph.IntermediateDataSetID;
+import org.apache.flink.runtime.jobgraph.IntermediateResultPartitionID;
+
+/**
+ * Representation of {@link IntermediateResultPartition}.
+ */
+public interface SchedulingResultPartition {
+
+ /**
+* Gets id of the result partition.
+*
+* @return id of the result partition
+*/
+ IntermediateResultPartitionID getId();
+
+ /**
+* Gets id of the intermediate result.
+*
+* @return id of the intermediate result
+*/
+ IntermediateDataSetID getResultId();
+
+ /**
+* Gets the {@link ResultPartitionType}.
+*
+* @return result partition type
+*/
+ ResultPartitionType getPartitionType();
+
+ /**
+* Gets the {@link ResultPartitionState}.
+*
+* @return result partition state
+*/
+ ResultPartitionState getState();
+
Review comment:
I guess not. There should just be read interfaces.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhuzhurk commented on a change in pull request #8233: [FLINK-12227] [runtime] introduce SchedulingStrategy interface
zhuzhurk commented on a change in pull request #8233: [FLINK-12227] [runtime]
introduce SchedulingStrategy interface
URL: https://github.com/apache/flink/pull/8233#discussion_r279176066
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/strategy/ExecutionVertexID.java
##
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.scheduler.strategy;
+
+import org.apache.flink.runtime.executiongraph.ExecutionVertex;
+import org.apache.flink.runtime.jobgraph.JobVertexID;
+
+import java.util.Objects;
+
+/**
+ * Id identifying {@link ExecutionVertex}.
+ */
+public class ExecutionVertexID {
+ private final JobVertexID jobVertexId;
+
+ private final int subtaskIndex;
+
+ public ExecutionVertexID(JobVertexID jobVertexId, int subtaskIndex) {
Review comment:
Could we have the get methods for jobVertexId and subtaskIndex? They can be
useful to match the JobGraph topology.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
