[GitHub] [flink] zjffdu commented on pull request #11895: [FLINK-10911][scala-shell] Enable flink-scala-shell with Scala 2.12
zjffdu commented on pull request #11895: URL: https://github.com/apache/flink/pull/11895#issuecomment-826331433 @aalexandrov Thanks for looking into this issue, here's 2 tickets that are related https://issues.apache.org/jira/browse/SPARK-1199 https://issues.apache.org/jira/browse/SPARK-17103 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] zjffdu commented on pull request #11895: [FLINK-10911][scala-shell] Enable flink-scala-shell with Scala 2.12
zjffdu commented on pull request #11895: URL: https://github.com/apache/flink/pull/11895#issuecomment-826331433 @aalexandrov Thanks for looking into this issue, here's 2 tickets that are related https://issues.apache.org/jira/browse/SPARK-1199 https://issues.apache.org/jira/browse/SPARK-17103 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] zjffdu commented on pull request #11895: [FLINK-10911][scala-shell] Enable flink-scala-shell with Scala 2.12
zjffdu commented on pull request #11895: URL: https://github.com/apache/flink/pull/11895#issuecomment-626482480 @aljoscha I found that the case class issue is caused by `FLINK-10493` which introduce `ScalaCaseClassSerializer`. In our internal flink branch which is based on 1.5 that has no `ScalaCaseClassSerializer` it works even when I use `repl-class-based` in scala shell. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] zjffdu commented on pull request #11895: [FLINK-10911][scala-shell] Enable flink-scala-shell with Scala 2.12
zjffdu commented on pull request #11895: URL: https://github.com/apache/flink/pull/11895#issuecomment-620390185 @aljoscha I found the reason why I ran it successfully last time. I only run `mvn test`, but should run `mvn verify`, otherwise the tests under scala folder is not executed. Regarding this issue, I found that after I use `repl-class-based`, CI can pass with scala-2.12. Maybe it is related with this (https://users.scala-lang.org/t/is-this-a-known-repl-bug/3271). But it causes the case class can not be used in scala-shell, which I talked with you before. How about we fix the case class issue later ? Because I think it is fixable, spark scala shell support case class, we can borrow some ideas from spark. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] zjffdu commented on pull request #11895: [FLINK-10911][scala-shell] Enable flink-scala-shell with Scala 2.12
zjffdu commented on pull request #11895: URL: https://github.com/apache/flink/pull/11895#issuecomment-619966748 It is weird, I remember I ran test successfully before, let me try it again. BTW, do you mean all the tests of scala 2.12 is not enabled in CI ? I thought only tests for flink scala shell is disabled, and I enable it in this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] zjffdu commented on pull request #11895: [FLINK-10911][scala-shell] Enable flink-scala-shell with Scala 2.12
zjffdu commented on pull request #11895: URL: https://github.com/apache/flink/pull/11895#issuecomment-619875502 @aljoscha What kind of error do you see ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] zjffdu commented on pull request #11895: [FLINK-10911][scala-shell] Enable flink-scala-shell with Scala 2.12
zjffdu commented on pull request #11895: URL: https://github.com/apache/flink/pull/11895#issuecomment-619481445 @tillrohrmann @aljoscha @zentol Could you help review this PR ? Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
