[GitHub] [flink] zoltar9264 commented on a diff in pull request #20103: [FLINK-28178][runtime-web] Show the delegated StateBackend and whethe…
zoltar9264 commented on code in PR #20103:
URL: https://github.com/apache/flink/pull/20103#discussion_r940970843
##
docs/layouts/shortcodes/generated/rest_v1_dispatcher.html:
##
@@ -2335,6 +2335,9 @@
"state_backend" : {
"type" : "string"
},
+"state_changelog_enabled" : {
+ "type" : "boolean"
+},
Review Comment:
Hi @rkhachatryan , here is
[#20103](https://github.com/apache/flink/pull/20103) .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] zoltar9264 commented on a diff in pull request #20103: [FLINK-28178][runtime-web] Show the delegated StateBackend and whethe…
zoltar9264 commented on code in PR #20103:
URL: https://github.com/apache/flink/pull/20103#discussion_r940969237
##
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/DefaultExecutionGraph.java:
##
@@ -517,7 +527,16 @@ public void failJobDueToTaskFailure(
registerJobStatusListener(checkpointCoordinator.createActivatorDeactivator());
}
-this.stateBackendName =
checkpointStateBackend.getClass().getSimpleName();
+if
(StateBackendLoader.isChangelogStateBackend(checkpointStateBackend)) {
+this.stateChangelogEnabled = TernaryBoolean.TRUE;
+StateBackend delegatedStateBackend =
+((DelegatingStateBackend)
checkpointStateBackend).getDelegatedStateBackend();
+this.stateBackendName =
delegatedStateBackend.getClass().getSimpleName();
+} else {
+this.stateChangelogEnabled = TernaryBoolean.FALSE;
+this.stateBackendName =
checkpointStateBackend.getClass().getSimpleName();
+}
+
Review Comment:
Thanks @rkhachatryan , good idea, I have modified as your suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] zoltar9264 commented on a diff in pull request #20103: [FLINK-28178][runtime-web] Show the delegated StateBackend and whethe…
zoltar9264 commented on code in PR #20103: URL: https://github.com/apache/flink/pull/20103#discussion_r929606940 ## flink-runtime-web/web-dashboard/src/app/pages/job/checkpoints/job-checkpoints.component.html: ## @@ -551,15 +551,15 @@ -Changelog state-backend -Enabled -Disabled +State Changelog +Enabled Review Comment: Thanks @fredia for your reminder ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] zoltar9264 commented on a diff in pull request #20103: [FLINK-28178][runtime-web] Show the delegated StateBackend and whethe…
zoltar9264 commented on code in PR #20103: URL: https://github.com/apache/flink/pull/20103#discussion_r923989858 ## flink-runtime-web/web-dashboard/src/app/pages/job/checkpoints/job-checkpoints.component.html: ## @@ -551,15 +551,15 @@ -Changelog state-backend -Enabled -Disabled +State Changelog Review Comment: Hi @Myasuka , how do you think about “Changelog of Flink State” ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] zoltar9264 commented on a diff in pull request #20103: [FLINK-28178][runtime-web] Show the delegated StateBackend and whethe…
zoltar9264 commented on code in PR #20103:
URL: https://github.com/apache/flink/pull/20103#discussion_r923988243
##
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/checkpoints/CheckpointConfigInfo.java:
##
@@ -65,6 +65,8 @@ public class CheckpointConfigInfo implements ResponseBody {
public static final String FIELD_NAME_CHECKPOINTS_AFTER_TASKS_FINISH =
"checkpoints_after_tasks_finish";
+public static final String FIELD_NAME_STATE_CHANGELOG = "state_changelog";
Review Comment:
Hi @Myasuka , I change it to 'state_changelog_enabled'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] zoltar9264 commented on a diff in pull request #20103: [FLINK-28178][runtime-web] Show the delegated StateBackend and whethe…
zoltar9264 commented on code in PR #20103:
URL: https://github.com/apache/flink/pull/20103#discussion_r921127174
##
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/AccessExecutionGraph.java:
##
@@ -176,6 +176,13 @@ public interface AccessExecutionGraph extends
JobStatusProvider {
*/
Optional getCheckpointStorageName();
+/**
+ * Returns whether the state changelog is enabled for this ExecutionGraph.
+ *
+ * @return true, if state changelog enabled, false otherwise.
+ */
+boolean isStateChangelogEnabled();
Review Comment:
Actually I think all place where `isChangelogStateBackendEnabled` appeared
should be `isStateChangelogEnabled`. But since these methods are not public API
for users , I can also accept `isChangelogStateBackendEnabled` for consistence.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] zoltar9264 commented on a diff in pull request #20103: [FLINK-28178][runtime-web] Show the delegated StateBackend and whethe…
zoltar9264 commented on code in PR #20103: URL: https://github.com/apache/flink/pull/20103#discussion_r920699386 ## flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ArchivedExecutionGraph.java: ## @@ -391,6 +400,7 @@ public static ArchivedExecutionGraph createSparseArchivedExecutionGraph( checkpointingSettings == null ? null : CheckpointStatsSnapshot.empty(), checkpointingSettings == null ? null : "Unknown", checkpointingSettings == null ? null : "Unknown", +false, Review Comment: Sorry @Myasuka , It's my cursoriness. I have updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] zoltar9264 commented on a diff in pull request #20103: [FLINK-28178][runtime-web] Show the delegated StateBackend and whethe…
zoltar9264 commented on code in PR #20103:
URL: https://github.com/apache/flink/pull/20103#discussion_r920700958
##
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/AccessExecutionGraph.java:
##
@@ -176,6 +176,13 @@ public interface AccessExecutionGraph extends
JobStatusProvider {
*/
Optional getCheckpointStorageName();
+/**
+ * Returns whether the state changelog is enabled for this ExecutionGraph.
+ *
+ * @return true, if state changelog enabled, false otherwise.
+ */
+boolean isStateChangelogEnabled();
Review Comment:
I think isStateChangelogEnabled is easier to understand, but I've also
noticed that isChangelogStateBackendEnabled has been used elsewhere. I don't
know how to choose, or is my understanding simply wrong?
cc @rkhachatryan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] zoltar9264 commented on a diff in pull request #20103: [FLINK-28178][runtime-web] Show the delegated StateBackend and whethe…
zoltar9264 commented on code in PR #20103:
URL: https://github.com/apache/flink/pull/20103#discussion_r920700958
##
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/AccessExecutionGraph.java:
##
@@ -176,6 +176,13 @@ public interface AccessExecutionGraph extends
JobStatusProvider {
*/
Optional getCheckpointStorageName();
+/**
+ * Returns whether the state changelog is enabled for this ExecutionGraph.
+ *
+ * @return true, if state changelog enabled, false otherwise.
+ */
+boolean isStateChangelogEnabled();
Review Comment:
I think isStateChangelogEnabled is easier to understand, but I've also
noticed that isChangelogStateBackendEnabled has been used elsewhere. I don't
know how to choose, or is my understanding simply wrong?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] zoltar9264 commented on a diff in pull request #20103: [FLINK-28178][runtime-web] Show the delegated StateBackend and whethe…
zoltar9264 commented on code in PR #20103: URL: https://github.com/apache/flink/pull/20103#discussion_r920699386 ## flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ArchivedExecutionGraph.java: ## @@ -391,6 +400,7 @@ public static ArchivedExecutionGraph createSparseArchivedExecutionGraph( checkpointingSettings == null ? null : CheckpointStatsSnapshot.empty(), checkpointingSettings == null ? null : "Unknown", checkpointingSettings == null ? null : "Unknown", +false, Review Comment: Sorry @Myasuka , It's my cursoriness. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] zoltar9264 commented on a diff in pull request #20103: [FLINK-28178][runtime-web] Show the delegated StateBackend and whethe…
zoltar9264 commented on code in PR #20103:
URL: https://github.com/apache/flink/pull/20103#discussion_r920678551
##
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/checkpoints/CheckpointConfigInfo.java:
##
@@ -65,6 +65,8 @@ public class CheckpointConfigInfo implements ResponseBody {
public static final String FIELD_NAME_CHECKPOINTS_AFTER_TASKS_FINISH =
"checkpoints_after_tasks_finish";
+public static final String FIELD_NAME_STATE_CHANGELOG = "state_changelog";
Review Comment:
How about 'state_changelog_enabled' ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] zoltar9264 commented on a diff in pull request #20103: [FLINK-28178][runtime-web] Show the delegated StateBackend and whethe…
zoltar9264 commented on code in PR #20103:
URL: https://github.com/apache/flink/pull/20103#discussion_r920675336
##
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/AccessExecutionGraph.java:
##
@@ -176,6 +176,13 @@ public interface AccessExecutionGraph extends
JobStatusProvider {
*/
Optional getCheckpointStorageName();
+/**
+ * Returns whether the state changelog is enabled for this ExecutionGraph.
+ *
+ * @return true, if state changelog enabled, false otherwise.
+ */
+boolean isStateChangelogEnabled();
Review Comment:
Hi @Myasuka , thanks for the suggession .I think ’State Changelog‘ is more
suitable to describe this feature, and ’ChangelogStateBackend‘ is the specific
implementation of it. WDYT ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
