[GitHub] [flink] zuston commented on pull request #18087: [FLINK-25268] Support task manager node-label in Yarn deployment
zuston commented on pull request #18087: URL: https://github.com/apache/flink/pull/18087#issuecomment-997564732 All done @KarmaGYZ Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] zuston commented on pull request #18087: [FLINK-25268] Support task manager node-label in Yarn deployment
zuston commented on pull request #18087: URL: https://github.com/apache/flink/pull/18087#issuecomment-996569666 @KarmaGYZ Thanks again. All done except the `instanceof ContainerRequestWithConstructor` assertion. Besides i have checked this PR in our internal Hadoop cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] zuston commented on pull request #18087: [FLINK-25268] Support task manager node-label in Yarn deployment
zuston commented on pull request #18087: URL: https://github.com/apache/flink/pull/18087#issuecomment-996469650 All done @KarmaGYZ Could you help review it again? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] zuston commented on pull request #18087: [FLINK-25268] Support task manager node-label in Yarn deployment
zuston commented on pull request #18087: URL: https://github.com/apache/flink/pull/18087#issuecomment-995547926 > You can build the doc with `mvn clean package -Dgenerate-config-docs -pl flink-docs -am -nsu -DskipTests -Dcheckstyle.skip`. Thanks @KarmaGYZ . Got it. Any other comments on it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] zuston commented on pull request #18087: [FLINK-25268] Support task manager node-label in Yarn deployment
zuston commented on pull request #18087: URL: https://github.com/apache/flink/pull/18087#issuecomment-994652792 @KarmaGYZ Could you help review it? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] zuston commented on pull request #18087: [FLINK-25268] Support task manager node-label in Yarn deployment
zuston commented on pull request #18087: URL: https://github.com/apache/flink/pull/18087#issuecomment-992139897 Could you help check this features? @wangyang0918 @KarmaGYZ Now this PR is just draft, if this feature could be invovled in Flink, i will optimize. And maybe jobmanager(Yarn application) node label should also be supported. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
