[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #367: [FLINK-29283] Remove hardcoded apiVersion from operator unit test

2022-09-18 Thread GitBox


gyfora commented on PR #367:
URL: 
https://github.com/apache/flink-kubernetes-operator/pull/367#issuecomment-1250236032

   I am closing this PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #367: [FLINK-29283] Remove hardcoded apiVersion from operator unit test

2022-09-14 Thread GitBox


gyfora commented on PR #367:
URL: 
https://github.com/apache/flink-kubernetes-operator/pull/367#issuecomment-1247020197

   Later if we feel like it we can parameterize these tests when new versions 
come around that change the serialization logic 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #367: [FLINK-29283] Remove hardcoded apiVersion from operator unit test

2022-09-14 Thread GitBox


gyfora commented on PR #367:
URL: 
https://github.com/apache/flink-kubernetes-operator/pull/367#issuecomment-1247019482

   Having hard coded versions serve as a basic form of backward compatibility 
test . I think we should not change these.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org