zhipeng93 commented on pull request #66:
URL: https://github.com/apache/flink-ml/pull/66#issuecomment-1050431249
Hi Dong, Thanks for the review.
> Could you confirm that the flaky test could be reproduced before this
patch but not after this patch?
I have repeatedly run this flaky test for up to 100 times and there is no
failures.
Do you mean that we need another test case for this bug fix? I think
`LogisticRegressionTest#testMoreSubtaskThanData` already covers this case ---
It sometimes fails before, but did not fail for 100 runs after this fix.
> And could you update the AllReduceImpl's Java doc to replace `only one
double array` with `up to one double array`? And maybe update allReduceSum()
Java doc similarly?
The java doc is updated and I also added one more test case to cover this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
