[GitHub] [flink-statefun-playground] nathantalewis commented on a change in pull request #17: Fix the Kubernetes example
nathantalewis commented on a change in pull request #17: URL: https://github.com/apache/flink-statefun-playground/pull/17#discussion_r799861406 ## File path: deployments/k8s/04-statefun/00-module.yaml ## @@ -5,11 +5,12 @@ metadata: name: module-config data: module.yaml: |+ -kind: io.statefun.endpoints.v2.http +kind: io.statefun.endpoints.v2/http spec: functions: example/* urlPathTemplate: http://functions.statefun.svc.cluster.local:8000/statefun transport: +type: io.statefun.transports.v1/okhttp Review comment: Great news! Everything worked in Statefun 3.2.0 even when `type` wasn't specified. I've pushed a new commit removing that line from this PR. 拾 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink-statefun-playground] nathantalewis commented on a change in pull request #17: Fix the Kubernetes example
nathantalewis commented on a change in pull request #17: URL: https://github.com/apache/flink-statefun-playground/pull/17#discussion_r799028134 ## File path: deployments/k8s/04-statefun/00-module.yaml ## @@ -5,11 +5,12 @@ metadata: name: module-config data: module.yaml: |+ -kind: io.statefun.endpoints.v2.http +kind: io.statefun.endpoints.v2/http spec: functions: example/* urlPathTemplate: http://functions.statefun.svc.cluster.local:8000/statefun transport: +type: io.statefun.transports.v1/okhttp Review comment: Hi @igalshilman! I'm trying to get the example to work in gke using a gcs connector instead of minio at the moment. Once I get that up and running then I'll be happy to swing back and see if `type` still needs to be specified here in 3.2.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
