[GitHub] [flink-web] chaojianok commented on pull request #247: [FLINK-13683] Translate "Code Style - Component Guide" page into Chinese

2020-06-16 Thread GitBox


chaojianok commented on pull request #247:
URL: https://github.com/apache/flink-web/pull/247#issuecomment-644697854


   @klion26 Thanks a lot for your review, I've optimized it according to your 
comments, please help me review again.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink-web] chaojianok commented on pull request #247: [FLINK-13683] Translate "Code Style - Component Guide" page into Chinese

2020-06-09 Thread GitBox


chaojianok commented on pull request #247:
URL: https://github.com/apache/flink-web/pull/247#issuecomment-641110194


   @klion26 Thanks a lot for your review, I've optimized it according to your 
comments, please help me review again.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink-web] chaojianok commented on pull request #247: [FLINK-13683] Translate "Code Style - Component Guide" page into Chinese

2020-06-07 Thread GitBox


chaojianok commented on pull request #247:
URL: https://github.com/apache/flink-web/pull/247#issuecomment-640346256


   @klion26 Thanks a lot for your review, I've optimized it according to your 
comments, please help me review again.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink-web] chaojianok commented on pull request #247: [FLINK-13683] Translate "Code Style - Component Guide" page into Chinese

2020-05-26 Thread GitBox


chaojianok commented on pull request #247:
URL: https://github.com/apache/flink-web/pull/247#issuecomment-633774837


   @klion26 Thanks a lot for your review, I've optimized it according to your 
comments, please help me review again.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink-web] chaojianok commented on pull request #247: [FLINK-13683] Translate "Code Style - Component Guide" page into Chinese

2020-05-22 Thread GitBox


chaojianok commented on pull request #247:
URL: https://github.com/apache/flink-web/pull/247#issuecomment-632518734


   @klion26 Thanks a lot for your review, I've optimized it according to your 
comments, please help me review again.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink-web] chaojianok commented on pull request #247: [FLINK-13683] Translate "Code Style - Component Guide" page into Chinese

2020-05-19 Thread GitBox


chaojianok commented on pull request #247:
URL: https://github.com/apache/flink-web/pull/247#issuecomment-630729514


   @klion26 Thanks a lot for your review, I've optimized it according to your 
comments, please help me review again.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink-web] chaojianok commented on pull request #247: [FLINK-13683] Translate "Code Style - Component Guide" page into Chinese

2020-05-14 Thread GitBox


chaojianok commented on pull request #247:
URL: https://github.com/apache/flink-web/pull/247#issuecomment-629033247


   @klion26 Thanks a lot for your review, I've optimized it according to your 
suggestions, please help me review again.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink-web] chaojianok commented on pull request #247: [FLINK-13683] Translate "Code Style - Component Guide" page into Chinese

2020-05-08 Thread GitBox


chaojianok commented on pull request #247:
URL: https://github.com/apache/flink-web/pull/247#issuecomment-625725721


   @klion26 Thanks for your suggestion, I've got rid of the `git merge` commit 
in the history.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org