[GitHub] GJL commented on a change in pull request #6718: [FLINK-9891] Add optional hook to shutdown cluster if a session was created in per-job mode in attached mode

2018-09-20 Thread GitBox 
GJL commented on a change in pull request #6718: [FLINK-9891] Add optional hook 
to shutdown cluster if a session was created in per-job mode in attached mode
URL: https://github.com/apache/flink/pull/6718#discussion_r219226146
 
 

 ##
 File path: 
flink-clients/src/main/java/org/apache/flink/client/cli/ProgramOptions.java
 ##
 @@ -57,6 +58,8 @@
 
private final boolean detachedMode;
 
+   private final boolean shutdownOnAttachedExist;
 
 Review comment:
   _exit_


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] GJL commented on a change in pull request #6718: [FLINK-9891] Add optional hook to shutdown cluster if a session was created in per-job mode in attached mode

2018-09-20 Thread GitBox 
GJL commented on a change in pull request #6718: [FLINK-9891] Add optional hook 
to shutdown cluster if a session was created in per-job mode in attached mode
URL: https://github.com/apache/flink/pull/6718#discussion_r219225730
 
 

 ##
 File path: 
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java
 ##
 @@ -492,11 +505,10 @@ private static void 
printJobStatusMessages(List jobs) {
jobsByState.entrySet().stream()
.sorted(statusComparator)

.map(Map.Entry::getValue).flatMap(List::stream).sorted(startTimeComparator)
-   .forEachOrdered(job -> {
-   System.out.println(dateFormat.format(new 
Date(job.getStartTime()))
-   + " : " + job.getJobId() + " : " + 
job.getJobName()
-   + " (" + job.getJobState() + ")");
-   });
+   .forEachOrdered(job ->
 
 Review comment:
   nit: unrelated formatting change?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] GJL commented on a change in pull request #6718: [FLINK-9891] Add optional hook to shutdown cluster if a session was created in per-job mode in attached mode

2018-09-20 Thread GitBox 
GJL commented on a change in pull request #6718: [FLINK-9891] Add optional hook 
to shutdown cluster if a session was created in per-job mode in attached mode
URL: https://github.com/apache/flink/pull/6718#discussion_r219231030
 
 

 ##
 File path: docs/ops/cli.md
 ##
 @@ -265,6 +269,10 @@ Action "run" compiles and runs a program.
   connect to a different JobManager 
than
   the one specified in the
   configuration.
+ -sae,--shutdownOnAttachedExitIf the job mode is not detached and a
 
 Review comment:
   I'd rephrase it a bit: _If the job is submitted in attached mode, perform a 
best-effort cluster shutdown when the CLI is terminated abruptly, e.g., in 
response to a user interrupt, such as typing Ctrl + C._ 
   
   If you don't like it, I'd at least change _the best effort cluster shutdown_ 
to _a best-effort cluster shutdown_


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] GJL commented on a change in pull request #6718: [FLINK-9891] Add optional hook to shutdown cluster if a session was created in per-job mode in attached mode

2018-09-20 Thread GitBox 
GJL commented on a change in pull request #6718: [FLINK-9891] Add optional hook 
to shutdown cluster if a session was created in per-job mode in attached mode
URL: https://github.com/apache/flink/pull/6718#discussion_r219226199
 
 

 ##
 File path: 
flink-clients/src/main/java/org/apache/flink/client/cli/ProgramOptions.java
 ##
 @@ -145,6 +149,10 @@ public boolean getDetachedMode() {
return detachedMode;
}
 
+   public boolean isShutdownOnAttachedExist() {
 
 Review comment:
   _exit_


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] GJL commented on a change in pull request #6718: [FLINK-9891] Add optional hook to shutdown cluster if a session was created in per-job mode in attached mode

2018-09-19 Thread GitBox 
GJL commented on a change in pull request #6718: [FLINK-9891] Add optional hook 
to shutdown cluster if a session was created in per-job mode in attached mode
URL: https://github.com/apache/flink/pull/6718#discussion_r218859953
 
 

 ##
 File path: docs/ops/cli.md
 ##
 @@ -265,6 +268,9 @@ Action "run" compiles and runs a program.
   connect to a different JobManager 
than
   the one specified in the
   configuration.
+ -sae,--schutdownOnAttachedExist  If the job mode is not detached and
 
 Review comment:
   Is this supposed to be _exit_ instead of _exist_? How about 
`--shutdownOnExit`?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] GJL commented on a change in pull request #6718: [FLINK-9891] Add optional hook to shutdown cluster if a session was created in per-job mode in attached mode

2018-09-19 Thread GitBox 
GJL commented on a change in pull request #6718: [FLINK-9891] Add optional hook 
to shutdown cluster if a session was created in per-job mode in attached mode
URL: https://github.com/apache/flink/pull/6718#discussion_r218853732
 
 

 ##
 File path: 
flink-clients/src/main/java/org/apache/flink/client/cli/ProgramOptions.java
 ##
 @@ -57,6 +58,8 @@
 
private final boolean detachedMode;
 
+   private final boolean schutdownOnAttachedExist;
 
 Review comment:
   _shutdown_


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] GJL commented on a change in pull request #6718: [FLINK-9891] Add optional hook to shutdown cluster if a session was created in per-job mode in attached mode

2018-09-19 Thread GitBox 
GJL commented on a change in pull request #6718: [FLINK-9891] Add optional hook 
to shutdown cluster if a session was created in per-job mode in attached mode
URL: https://github.com/apache/flink/pull/6718#discussion_r218853427
 
 

 ##
 File path: docs/ops/cli.md
 ##
 @@ -257,6 +257,9 @@ Action "run" compiles and runs a program.
  -s,--fromSavepointPath to a savepoint to restore the 
job
   from (for example
   hdfs:///flink/savepoint-1537).
+ -sae,--schutdownOnAttachedExist  If the job mode is not detached and
 
 Review comment:
   _shutdown_


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services