[GitHub] Guibo-Pan commented on a change in pull request #6591: [FLINK-10186] Fix FindBugs warnings: Random object created and used o…
Guibo-Pan commented on a change in pull request #6591: [FLINK-10186] Fix
FindBugs warnings: Random object created and used o…
URL: https://github.com/apache/flink/pull/6591#discussion_r212410516
##
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/BufferSpiller.java
##
@@ -115,7 +115,7 @@ public BufferSpiller(IOManager ioManager, int pageSize)
throws IOException {
this.tempDir = tempDirs[DIRECTORY_INDEX.getAndIncrement() %
tempDirs.length];
byte[] rndBytes = new byte[32];
- new Random().nextBytes(rndBytes);
Review comment:
It's inside constructor method, and just randoms for once in an instance.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] Guibo-Pan commented on a change in pull request #6591: [FLINK-10186] Fix FindBugs warnings: Random object created and used o…
Guibo-Pan commented on a change in pull request #6591: [FLINK-10186] Fix
FindBugs warnings: Random object created and used o…
URL: https://github.com/apache/flink/pull/6591#discussion_r212410516
##
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/BufferSpiller.java
##
@@ -115,7 +115,7 @@ public BufferSpiller(IOManager ioManager, int pageSize)
throws IOException {
this.tempDir = tempDirs[DIRECTORY_INDEX.getAndIncrement() %
tempDirs.length];
byte[] rndBytes = new byte[32];
- new Random().nextBytes(rndBytes);
Review comment:
It's inside constructor method, and just randoms for once in an instance.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
