[GitHub] StefanRRichter commented on issue #6994: [FLINK-10720][tests] Add deployment end-to-end stress test with many …
StefanRRichter commented on issue #6994: [FLINK-10720][tests] Add deployment end-to-end stress test with many … URL: https://github.com/apache/flink/pull/6994#issuecomment-436309544 Thanks @tillrohrmann! Merging. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] StefanRRichter commented on issue #6994: [FLINK-10720][tests] Add deployment end-to-end stress test with many …
StefanRRichter commented on issue #6994: [FLINK-10720][tests] Add deployment end-to-end stress test with many … URL: https://github.com/apache/flink/pull/6994#issuecomment-436180186 @tillrohrmann thanks for pointing that out. I removed the dependency and rebased again. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] StefanRRichter commented on issue #6994: [FLINK-10720][tests] Add deployment end-to-end stress test with many …
StefanRRichter commented on issue #6994: [FLINK-10720][tests] Add deployment end-to-end stress test with many … URL: https://github.com/apache/flink/pull/6994#issuecomment-435873769 Alright, I limited the attempts to 3 and rebased to master. @tillrohrmann can you take a final look to give the thumbs up? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] StefanRRichter commented on issue #6994: [FLINK-10720][tests] Add deployment end-to-end stress test with many …
StefanRRichter commented on issue #6994: [FLINK-10720][tests] Add deployment end-to-end stress test with many … URL: https://github.com/apache/flink/pull/6994#issuecomment-435797556 @tillrohrmann I addressed all your comments except the one with the open question from my last comment. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] StefanRRichter commented on issue #6994: [FLINK-10720][tests] Add deployment end-to-end stress test with many …
StefanRRichter commented on issue #6994: [FLINK-10720][tests] Add deployment end-to-end stress test with many … URL: https://github.com/apache/flink/pull/6994#issuecomment-435449615 @tillrohrmann that depends how we want to interpret the result. Right now, the test is passed when it somehow manages to do one successsful recovery. If we want to test that the first recovery must already be successful, we could limit the number of allowed failed attempts to 1. Would you prefer to enforce succesful recovery in the first attempt? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] StefanRRichter commented on issue #6994: [FLINK-10720][tests] Add deployment end-to-end stress test with many …
StefanRRichter commented on issue #6994: [FLINK-10720][tests] Add deployment end-to-end stress test with many … URL: https://github.com/apache/flink/pull/6994#issuecomment-435314346 I have addressed your comments. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services