[GitHub] StephanEwen commented on issue #6724: [FLINK-10380] Add precondition for assignToKeyGroup method
StephanEwen commented on issue #6724: [FLINK-10380] Add precondition for assignToKeyGroup method URL: https://github.com/apache/flink/pull/6724#issuecomment-424788457 Concerning the other method you mentioned: That one is never used on the critical path, so things may be different there. Catching the null value earlier may be a more clean fix even. But again, we should not introduce branches if avoidable. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] StephanEwen commented on issue #6724: [FLINK-10380] Add precondition for assignToKeyGroup method
StephanEwen commented on issue #6724: [FLINK-10380] Add precondition for assignToKeyGroup method URL: https://github.com/apache/flink/pull/6724#issuecomment-423270421 This is on the performance critical path. Can we solve this another way that does not involve additional branches? An example would be catching the exception and enriching it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
