[GitHub] TisonKun commented on issue #6491: [FLINK-10057] Update FlinkYarnSessionCli.java

2018-10-18 Thread GitBox
TisonKun commented on issue #6491: [FLINK-10057] Update FlinkYarnSessionCli.java
URL: https://github.com/apache/flink/pull/6491#issuecomment-430986516
 
 
   Thanks for the pick-up @GJL !


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] TisonKun commented on issue #6491: [FLINK-10057] Update FlinkYarnSessionCli.java

2018-09-28 Thread GitBox
TisonKun commented on issue #6491: [FLINK-10057] Update FlinkYarnSessionCli.java
URL: https://github.com/apache/flink/pull/6491#issuecomment-425415727
 
 
   @uce I understand your concerned and sorry to involve you here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] TisonKun commented on issue #6491: [FLINK-10057] Update FlinkYarnSessionCli.java

2018-09-27 Thread GitBox
TisonKun commented on issue #6491: [FLINK-10057] Update FlinkYarnSessionCli.java
URL: https://github.com/apache/flink/pull/6491#issuecomment-425333772
 
 
   @lzqdename From my side this pull request goes the right direction and now 
it is ready to be merged.
   
   However, I am not a committer who has the right to merge you PR. What I can 
do is show my approval and ping some committers for you to ask for a 
review/decision.
   
   Please note that ASF [states 
that](http://www.apache.org/dev/contributors#patches):
   ```
   Please show some patience with the developers if your patch is not applied 
as fast as you'd like or a developer asks you to make changes to the patch. If 
you do not receive any feedback in a reasonable amount of time (say a week or 
two), feel free to send a follow-up e-mail to the developer list. Open Source 
developers are all volunteers, often doing the development in their spare time.
   ```
   
   cc @kl0u @uce @sihuazhou 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] TisonKun commented on issue #6491: [FLINK-10057] Update FlinkYarnSessionCli.java

2018-08-04 Thread GitBox
TisonKun commented on issue #6491: [FLINK-10057] Update FlinkYarnSessionCli.java
URL: https://github.com/apache/flink/pull/6491#issuecomment-410494126
 
 
   cc @twalthr @StephanEwen 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] TisonKun commented on issue #6491: [FLINK-10057] Update FlinkYarnSessionCli.java

2018-08-04 Thread GitBox
TisonKun commented on issue #6491: [FLINK-10057] Update FlinkYarnSessionCli.java
URL: https://github.com/apache/flink/pull/6491#issuecomment-410489497
 
 
   @lzqdename thanks for your PR!
   this change makes sense. you could pay attention to the code style by 
looking at code around, and it would be better if you modify the information of 
PR as PULL_REQUEST_TEMPLATE suggested( it is the long text you paste above ).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services