[GitHub] TisonKun commented on issue #6643: [FLINK-10275] StreamTask support object reuse
TisonKun commented on issue #6643: [FLINK-10275] StreamTask support object reuse URL: https://github.com/apache/flink/pull/6643#issuecomment-418236948 This pull request would affect reusing of object from network, according to [FLIP-21](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=71012982), it is another reuse aspect from current `ExecutionConfig#isObjectReuseEnable` configuration. Travis fails on `TableSinkITCase#testAppendSinkOnAppendTableForInnerJoin` which is because of mutating inputValue. We need a extra config to switch network aspect object reuse. Still digging... Suggestions are welcome :-) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] TisonKun commented on issue #6643: [FLINK-10275] StreamTask support object reuse
TisonKun commented on issue #6643: [FLINK-10275] StreamTask support object reuse URL: https://github.com/apache/flink/pull/6643#issuecomment-420289282 @kl0u Thanks for comments! I would clean this PR and emphases the main changes later. Recently working on other threads, ping here once done. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] TisonKun commented on issue #6643: [FLINK-10275] StreamTask support object reuse
TisonKun commented on issue #6643: [FLINK-10275] StreamTask support object reuse URL: https://github.com/apache/flink/pull/6643#issuecomment-420644895 @StephanEwen you're right. After raising the exception mentioned above I communicate with our batch team, who pointing me to FLIP-21. So this thread stalls until the corresponding patch from batch size given out. Still under discussion and attempts. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] TisonKun commented on issue #6643: [FLINK-10275] StreamTask support object reuse
TisonKun commented on issue #6643: [FLINK-10275] StreamTask support object reuse URL: https://github.com/apache/flink/pull/6643#issuecomment-421020528 Although I don't think remain a stall pull request does harm, since this pull request should be updated nearly as a rework, I would close it. Thanks for your reminding @kl0u! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
