[GitHub] aljoscha commented on issue #6615: [FLINK-8354] [flink-connectors] Add ability to access and provider Kafka headers

2019-02-21 Thread GitBox
aljoscha commented on issue #6615: [FLINK-8354] [flink-connectors] Add ability 
to access and provider Kafka headers
URL: https://github.com/apache/flink/pull/6615#issuecomment-465934548
 
 
   Closing because we have the other PRs.
   
   Thanks for pushing this @alexeyt820!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] aljoscha commented on issue #6615: [FLINK-8354] [flink-connectors] Add ability to access and provider Kafka headers

2019-02-20 Thread GitBox
aljoscha commented on issue #6615: [FLINK-8354] [flink-connectors] Add ability 
to access and provider Kafka headers
URL: https://github.com/apache/flink/pull/6615#issuecomment-465647551
 
 
   I created rebased PRs that have separate commits to be easier to review: 
#7781 and #7782


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] aljoscha commented on issue #6615: [FLINK-8354] [flink-connectors] Add ability to access and provider Kafka headers

2019-02-20 Thread GitBox
aljoscha commented on issue #6615: [FLINK-8354] [flink-connectors] Add ability 
to access and provider Kafka headers
URL: https://github.com/apache/flink/pull/6615#issuecomment-465559418
 
 
   @alexeyt820 Please don't push any more changes right now. I'm having a look 
at this PR and might shuffle a few things around and rebase it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] aljoscha commented on issue #6615: [FLINK-8354] [flink-connectors] Add ability to access and provider Kafka headers

2018-09-13 Thread GitBox
aljoscha commented on issue #6615: [FLINK-8354] [flink-connectors] Add ability 
to access and provider Kafka headers
URL: https://github.com/apache/flink/pull/6615#issuecomment-421038704
 
 
   For this, I would await the outcome of #6577. If we end up only having one 
"modern" Kafka connector we might just pass through the `ConsumerRecord`. 
Otherwise we might have to do some wrapping.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] aljoscha commented on issue #6615: [FLINK-8354] [flink-connectors] Add ability to access and provider Kafka headers

2018-08-29 Thread GitBox
aljoscha commented on issue #6615: [FLINK-8354] [flink-connectors] Add ability 
to access and provider Kafka headers
URL: https://github.com/apache/flink/pull/6615#issuecomment-416972143
 
 
   Hi, we have to carefully coordinate this with #6105 and and #6577. See 
especially my comments on #6577.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services