[GitHub] azagrebin commented on a change in pull request #6989: [FLINK-10455][Kafka Tx] Close transactional producers in case of failure and termination

2018-11-14 Thread GitBox 
azagrebin commented on a change in pull request #6989: [FLINK-10455][Kafka Tx] 
Close transactional producers in case of failure and termination
URL: https://github.com/apache/flink/pull/6989#discussion_r233363582
 
 

 ##
 File path: 
flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011.java
 ##
 @@ -671,6 +672,9 @@ public void close() throws FlinkKafka011Exception {
}
// make sure we propagate pending errors
checkErroneous();
+   pendingTransactions().values().forEach(transaction ->
 
 Review comment:
   I created FLINK-10876 to look into this deadlock


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] azagrebin commented on a change in pull request #6989: [FLINK-10455][Kafka Tx] Close transactional producers in case of failure and termination

2018-11-02 Thread GitBox 
azagrebin commented on a change in pull request #6989: [FLINK-10455][Kafka Tx] 
Close transactional producers in case of failure and termination
URL: https://github.com/apache/flink/pull/6989#discussion_r230447543
 
 

 ##
 File path: 
flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011.java
 ##
 @@ -671,6 +672,9 @@ public void close() throws FlinkKafka011Exception {
}
// make sure we propagate pending errors
checkErroneous();
+   pendingTransactions().values().forEach(transaction ->
 
 Review comment:
   `TransactionManager#maybeFailWithError` contains just a check, it does not 
help with the deadlock so far


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services