[GitHub] casidiablo commented on issue #2671: [FLINK-4862] fix Timer register in ContinuousEventTimeTrigger

2019-01-30 Thread GitBox
casidiablo commented on issue #2671: [FLINK-4862] fix Timer register in 
ContinuousEventTimeTrigger
URL: https://github.com/apache/flink/pull/2671#issuecomment-459222191
 
 
   I don't have enough time to fix this. I documented what I found here 
https://issues.apache.org/jira/browse/FLINK-11408 though 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] casidiablo commented on issue #2671: [FLINK-4862] fix Timer register in ContinuousEventTimeTrigger

2019-01-18 Thread GitBox
casidiablo commented on issue #2671: [FLINK-4862] fix Timer register in 
ContinuousEventTimeTrigger
URL: https://github.com/apache/flink/pull/2671#issuecomment-455662386
 
 
   This does seems to happen for `ContinuousProcessingTimeTrigger` too. Its 
clear method NPEs when clearing the window:
   
   ```java
@Override
public void clear(W window, TriggerContext ctx) throws Exception {
ReducingState fireTimestamp = 
ctx.getPartitionedState(stateDesc);
long timestamp = fireTimestamp.get();
ctx.deleteProcessingTimeTimer(timestamp);
fireTimestamp.clear();
}
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services