[GitHub] fhueske commented on a change in pull request #6666: [FLINK-10290] [table] Fix conversion error in StreamScan and BatchScan

2018-09-13 Thread GitBox 
fhueske commented on a change in pull request #: [FLINK-10290] [table] Fix 
conversion error in StreamScan and BatchScan
URL: https://github.com/apache/flink/pull/#discussion_r217547586
 
 

 ##
 File path: 
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/table/TableSourceITCase.scala
 ##
 @@ -778,4 +778,42 @@ class TableSourceITCase extends AbstractTestBase {
 assertEquals(expected.sorted, StreamITCase.testResults.sorted)
   }
 
+  @Test
+  def testTableSourceScanWithConversion(): Unit = {
 
 Review comment:
   Rename to `testTableSourceScanWithPermutedFields()`?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] fhueske commented on a change in pull request #6666: [FLINK-10290] [table] Fix conversion error in StreamScan and BatchScan

2018-09-13 Thread GitBox 
fhueske commented on a change in pull request #: [FLINK-10290] [table] Fix 
conversion error in StreamScan and BatchScan
URL: https://github.com/apache/flink/pull/#discussion_r217545093
 
 

 ##
 File path: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/StreamScan.scala
 ##
 @@ -50,11 +51,12 @@ trait StreamScan extends CommonScan[CRow] with 
DataStreamRel {
   f == TimeIndicatorTypeInfo.ROWTIME_STREAM_MARKER ||
   f == TimeIndicatorTypeInfo.PROCTIME_STREAM_MARKER)
 
-if (input.getType == cRowType && !hasTimeIndicator) {
+if (inputType == cRowType && !hasTimeIndicator) {
 
 Review comment:
   Would also be good to have a test for this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] fhueske commented on a change in pull request #6666: [FLINK-10290] [table] Fix conversion error in StreamScan and BatchScan

2018-09-13 Thread GitBox 
fhueske commented on a change in pull request #: [FLINK-10290] [table] Fix 
conversion error in StreamScan and BatchScan
URL: https://github.com/apache/flink/pull/#discussion_r217547642
 
 

 ##
 File path: 
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/table/TableSourceITCase.scala
 ##
 @@ -742,6 +742,42 @@ class TableSourceITCase(
 TestBaseUtils.compareResultAsText(results.asJava, expected)
   }
 
+  @Test
+  def testTableSourceScanWithConversion(): Unit = {
 
 Review comment:
   Rename to `testTableSourceScanWithPermutedFields`?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] fhueske commented on a change in pull request #6666: [FLINK-10290] [table] Fix conversion error in StreamScan and BatchScan

2018-09-13 Thread GitBox 
fhueske commented on a change in pull request #: [FLINK-10290] [table] Fix 
conversion error in StreamScan and BatchScan
URL: https://github.com/apache/flink/pull/#discussion_r217544935
 
 

 ##
 File path: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/StreamScan.scala
 ##
 @@ -50,11 +51,12 @@ trait StreamScan extends CommonScan[CRow] with 
DataStreamRel {
   f == TimeIndicatorTypeInfo.ROWTIME_STREAM_MARKER ||
   f == TimeIndicatorTypeInfo.PROCTIME_STREAM_MARKER)
 
-if (input.getType == cRowType && !hasTimeIndicator) {
+if (inputType == cRowType && !hasTimeIndicator) {
 
 Review comment:
   `CRowTypeInfo` doesn't check for field name equality either. Can you add a 
`schemaEquals()` method to `CRowTypeInfo` and call this here?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services