[GitHub] flink issue #2214: [FLINK-4019][kinesis-connector] Use Kinesis records' appr...

2016-07-08 Thread rmetzger
Github user rmetzger commented on the issue:

https://github.com/apache/flink/pull/2214
  
+1 to merge once travis is green.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink issue #2214: [FLINK-4019][kinesis-connector] Use Kinesis records' appr...

2016-07-08 Thread tzulitai
Github user tzulitai commented on the issue:

https://github.com/apache/flink/pull/2214
  
@rmetzger Thank you for the review. Comments addressed :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink issue #2214: [FLINK-4019][kinesis-connector] Use Kinesis records' appr...

2016-07-08 Thread rmetzger
Github user rmetzger commented on the issue:

https://github.com/apache/flink/pull/2214
  
Thx for rebasing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink issue #2214: [FLINK-4019][kinesis-connector] Use Kinesis records' appr...

2016-07-08 Thread tzulitai
Github user tzulitai commented on the issue:

https://github.com/apache/flink/pull/2214
  
Rebasing ...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink issue #2214: [FLINK-4019][kinesis-connector] Use Kinesis records' appr...

2016-07-07 Thread tzulitai
Github user tzulitai commented on the issue:

https://github.com/apache/flink/pull/2214
  
@rmetzger can you also help review this PR for the Kinesis connector too? 
Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---