[GitHub] flink issue #2431: [FLINK-4521][web frontend] Fix "Submit new Job" panel in ...
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2431 @rmetzger and @iampeter What do you think about this pull request? Does this fit with the current Web UI efforts? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2431: [FLINK-4521][web frontend] Fix "Submit new Job" panel in ...
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2431 Hi @iampeter Thank you for your review and sorry for the long delay. I'll update the code in the next few days. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2431: [FLINK-4521][web frontend] Fix "Submit new Job" panel in ...
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2431 Hi @iampeter I've fixed the code according to your review. Could you please review it again? Best regards, Ivan. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2431: [FLINK-4521][web frontend] Fix "Submit new Job" panel in ...
Github user iampeter commented on the issue: https://github.com/apache/flink/pull/2431 @mushketyk looks good, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2431: [FLINK-4521][web frontend] Fix "Submit new Job" panel in ...
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2431 Hi @iampeter Thank you for your review. Do I need to rebase this PR to merge it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2431: [FLINK-4521][web frontend] Fix "Submit new Job" panel in ...
Github user iampeter commented on the issue: https://github.com/apache/flink/pull/2431 @mushketyk I suppose so, right @rmetzger ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2431: [FLINK-4521][web frontend] Fix "Submit new Job" panel in ...
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2431 @rmetzger @iampeter I've rebased my PR on top of mainline. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2431: [FLINK-4521][web frontend] Fix "Submit new Job" panel in ...
Github user uce commented on the issue: https://github.com/apache/flink/pull/2431 Sorry for the long delay with this one. The jar request URL has been fixed in another PR by now. This leaves the refactoring with the util instead of manually concatenating the URL. Should we change this @iampeter? I like it, but we would have to rebase this yet again as new requests have been added in the mean time. Sorry again for the long delay. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2431: [FLINK-4521][web frontend] Fix "Submit new Job" panel in ...
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2431 Hi @uce, No worries about the long delay. Just write here if you decide to merge it and I'll rebase it. Best regards, Ivan. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2431: [FLINK-4521][web frontend] Fix "Submit new Job" panel in ...
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2431 Hi @uce I tried the latest version in the `master` branch and it seems that submit does not work there. https://cloud.githubusercontent.com/assets/592286/22408446/eefd13c0-e670-11e6-9831-0fc6d3c7aaef.png";> I rebased my PR on top and tested it and it seems to work fine. Are you sure that all issues with submit were fixed in current version? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
