[GitHub] flink issue #2467: [FLINK-3719][web frontend] Moving the barrier between gra...
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2467 Merging this ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2467: [FLINK-3719][web frontend] Moving the barrier between gra...
Github user iampeter commented on the issue: https://github.com/apache/flink/pull/2467 @mushketyk do make sure that the generated files are up-to-date (if they're not) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2467: [FLINK-3719][web frontend] Moving the barrier between gra...
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2467 @iampeter Is there anything else that I should change? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2467: [FLINK-3719][web frontend] Moving the barrier between gra...
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2467 Hi @iampeter I've updated the PR according to your review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2467: [FLINK-3719][web frontend] Moving the barrier between gra...
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2467 Hi @iampeter I've updated the PR according to your comments. Could you please review it again? Best regards, Ivan. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2467: [FLINK-3719][web frontend] Moving the barrier between gra...
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2467 Hi @iampeter, Sorry for the delay in response. I'll take a look at this on Sunday. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2467: [FLINK-3719][web frontend] Moving the barrier between gra...
Github user iampeter commented on the issue:
https://github.com/apache/flink/pull/2467
Thanks, that's better @mushketyk, but I think would be even better if you
did not identify the elements explicitly by ids ('#canvas', '#job-panel'), but
have the directive contain the two splitable parts, i.e.:
```
Upper part
Lower part
```
and just use the first and second child to identify them. This way the
directive would be reusable and also could be used in other parts of the
dashboard.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2467: [FLINK-3719][web frontend] Moving the barrier between gra...
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2467 Hi @iampeter @StephanEwen I've fixed the PR according to your review. I've added new license, introduced a new directive, and updated CSS. Could you please review it once again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2467: [FLINK-3719][web frontend] Moving the barrier between gra...
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2467 Hi @iampeter Thank you for your review. I'll update the code according to your suggestions. Best regards, Ivan. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2467: [FLINK-3719][web frontend] Moving the barrier between gra...
Github user iampeter commented on the issue: https://github.com/apache/flink/pull/2467 @mushketyk thanks for this feature, very useful indeed. I'd like to ask you to reconsider some things: 1. First of all, I think it would be good to wrap split.js in an Angular directive 2. I think the `style` attribute could be replaced by CSS 3. I think there is a typo in the port numer (80801) Let me know your thoughts. Thanks, Piotr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2467: [FLINK-3719][web frontend] Moving the barrier between gra...
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2467 Piotr (who wrote most of the web ui) also wants to leave some comments. Let's wait for him. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2467: [FLINK-3719][web frontend] Moving the barrier between gra...
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2467 The license is MIT, so that is fine. Can you update the LICENSE file with the dependency? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2467: [FLINK-3719][web frontend] Moving the barrier between gra...
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2467 Hi @StephanEwen All images are coming from this repo: https://github.com/nathancahill/Split.js It has a very permissive license: https://github.com/nathancahill/Split.js/blob/master/LICENSE.txt --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2467: [FLINK-3719][web frontend] Moving the barrier between gra...
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2467 This is a useful extension. I have pinged someone with more web UI experience to take a look at how it is implemented. Concerning licenses: Where are the png images for the sliders from? Were they self-created? In the case of other binary files, we usually left a text file in the directory stating the origin and license of the files. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
