[GitHub] flink issue #2469: [FLINK-4572] [gelly] Convert to negative in LongValueToIn...
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2469 I split the long to int translator into both signed and unsigned translators so the conversion would not be ambiguous. The test will fail without the fix in FLINK-4594. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2469: [FLINK-4572] [gelly] Convert to negative in LongValueToIn...
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2469 Do you have a second use case in mind for adding this function to `MathUtils`? My thought would be to keep this separate to avoid confusion between signed and unsigned downcasts. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2469: [FLINK-4572] [gelly] Convert to negative in LongValueToIn...
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2469 Looks good. Does it make sense to add to extend the `MathUtils.checkedDownCast(...)` function, or add a `MathUtils.checkedSignedDownCast(...)` function? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
