[GitHub] flink issue #2671: [FLINK-4862] fix Timer register in ContinuousEventTimeTri...
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2671 Thanks for having a look @aljoscha. Thanks again for the PR @manuzhang. Merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2671: [FLINK-4862] fix Timer register in ContinuousEventTimeTri...
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2671 @mxm @manuzhang Yes, the timers will be ignored because there is a check in `onEventTime()`. The fix looks good! Will you go ahead and merge, @mxm? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2671: [FLINK-4862] fix Timer register in ContinuousEventTimeTri...
Github user manuzhang commented on the issue: https://github.com/apache/flink/pull/2671 @mxm updated. Thanks for teaching me more about the internals. Ignoring the old Timer make things much simpler actually. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
