[GitHub] flink issue #2958: [FLINK-4704] Move Table API to org.apache.flink.table
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/2958 I looked over the changes again. LGTM also from my side. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2958: [FLINK-4704] Move Table API to org.apache.flink.table
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2958 Merging this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2958: [FLINK-4704] Move Table API to org.apache.flink.table
Github user ex00 commented on the issue: https://github.com/apache/flink/pull/2958 Thank you Fabian! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2958: [FLINK-4704] Move Table API to org.apache.flink.table
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2958 Thanks for the update @ex00! I'll do a few additional minor refactorings and merge the PR later. Thanks, Fabian --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2958: [FLINK-4704] Move Table API to org.apache.flink.table
Github user ex00 commented on the issue: https://github.com/apache/flink/pull/2958 PR has been updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2958: [FLINK-4704] Move Table API to org.apache.flink.table
Github user ex00 commented on the issue: https://github.com/apache/flink/pull/2958 Hi @fhueske and @twalthr, thanks for your comments. I will update PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2958: [FLINK-4704] Move Table API to org.apache.flink.table
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2958 OK @twalthr. Sounds good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2958: [FLINK-4704] Move Table API to org.apache.flink.table
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/2958 @fhueske I would move `src/main/scala/org/apache/flink/table/Types.scala` to `src/main/scala/org/apache/flink/table/api/`. This class is API only and and not used internally. And `src/main/scala/org/apache/flink/table/table.scala` -> `src/main/scala/org/apache/flink/table/api/`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2958: [FLINK-4704] Move Table API to org.apache.flink.table
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2958 Thanks for the PR @ex00! I would like to suggest to move a few more files: - move `flink-table` examples: `org/apache/flink/examples` -> `org/apache/flink/table/examples` (for Java and Scala) - move `src/main/scala/org/apache/flink/table/windows.scala` -> `src/main/scala/org/apache/flink/table/api/windows.scala` - move `src/main/scala/org/apache/flink/table/Types.scala` -> `src/main/scala/org/apache/flink/table/typeutils/Types.scala` - move `src/main/scala/org/apache/flink/table/trees/TreeNode.scala` -> `src/main/scala/org/apache/flink/table/plan/TreeNode.scala` and remove the empty `trees` package / folder - create a new package `org.apache.flink.table.calcite` and move `CalciteConfig.scala`, `FlinkCalciteSqlValidator.scala`, `FlinkPlannerImpl.scala`, `FlinkRelBuilder.scala`, `FlinkTypeFactory.scala`, and `FlinkTypeSystem.scala` from `src/main/scala/org/apache/flink/table` to `src/main/scala/org/apache/flink/table/calcite` What do you think @ex00 and @twalthr? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
