[GitHub] flink issue #3150: [FLINK-4693][tableApi] Add session group-windows for batc...
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/3150 Thanks for the update @sunjincheng121. The changes look good. I will merge this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3150: [FLINK-4693][tableApi] Add session group-windows for batc...
Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/3150 @fhueske I have updated the PR according to your comments.The change information is as followsï¼ 1. Fix "remember and read input objects across method calls". 2. Amend some code format. thanks again. SunJincheng. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3150: [FLINK-4693][tableApi] Add session group-windows for batc...
Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/3150 @fhueske Thank you very much for your detailed review, your optimization suggestion is that I should be concerned, I will update the PR as soon as possible. Thanks again!!! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3150: [FLINK-4693][tableApi] Add session group-windows for batc...
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/3150 The PR looks good to me, +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3150: [FLINK-4693][tableApi] Add session group-windows for batc...
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/3150 Thanks for updating the PR. +1 to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3150: [FLINK-4693][tableApi] Add session group-windows for batc...
Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/3150 Hi, @twalthr thanks a lot for the review. I have updated the PR according to your comments. Let me know if I miss somethingï¼thanks again!! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3150: [FLINK-4693][tableApi] Add session group-windows for batc...
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/3150 Btw it is not necessary to close and open a new PR after rebasing. You can simply perform a force push. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3150: [FLINK-4693][tableApi] Add session group-windows for batc...
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/3150 Thanks for updating the PR @sunjincheng121. I will shepherd this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3150: [FLINK-4693][tableApi] Add session group-windows for batc...
Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/3150 @fhueske @twalthr I reopened the PR and propose the design doc. https://docs.google.com/document/d/1WIOKNwfTW8nMZsRVL-ANIzxIiuXqVNGxwjiPj7go7hg/edit --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
