[GitHub] flink issue #3327: [FLINK-5616] [tests] Harden YarnIntraNonHaMasterServicesT...

2017-02-17 Thread tillrohrmann
Github user tillrohrmann commented on the issue:

https://github.com/apache/flink/pull/3327
  
Travis now passed :-) Merging this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink issue #3327: [FLINK-5616] [tests] Harden YarnIntraNonHaMasterServicesT...

2017-02-16 Thread tillrohrmann
Github user tillrohrmann commented on the issue:

https://github.com/apache/flink/pull/3327
  
True, this does not make much sense, what I've done here. Somehow I was 
under the assumption that `verify` will block until the call happened when I 
wrote it. Will correct it. Thanks for the review :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink issue #3327: [FLINK-5616] [tests] Harden YarnIntraNonHaMasterServicesT...

2017-02-16 Thread StephanEwen
Github user StephanEwen commented on the issue:

https://github.com/apache/flink/pull/3327
  
I am wondering if this is the same as the original timeout meaning.

I though that using `verify` with a timeout will wait for a while until the 
call must have happened. Without the timeout, the verification will fail if the 
call had not happened by the time the verification runs.

Adding the timeout to the test as a whole means that the test may not take 
longer than that timeout.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---