[GitHub] flink issue #3354: [FLINK-5767] [Table] New aggregate function interface and...

2017-02-22 Thread shaoxuan-wang
Github user shaoxuan-wang commented on the issue:

https://github.com/apache/flink/pull/3354
  
@fhueske  thanks for the review. I agree with you that we should provide 
more specific types for the accumulators (backend state). I will update code 
today to address all your comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink issue #3354: [FLINK-5767] [Table] New aggregate function interface and...

2017-02-19 Thread shaoxuan-wang
Github user shaoxuan-wang commented on the issue:

https://github.com/apache/flink/pull/3354
  
The travis-ci test build failed as it hits the Travis 50 min limit: "The 
job exceeded the maximum time limit for jobs, and has been terminated".  Robert 
has a fix for this FLINK-5731. Hope this won't block the review process. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---