[GitHub] flink issue #3502: [FLINK-4565] Support for SQL IN operator
Github user DmytroShkvyra commented on the issue: https://github.com/apache/flink/pull/3502 @Xpray I also wondered when will this PR be merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3502: [FLINK-4565] Support for SQL IN operator
Github user Xpray commented on the issue: https://github.com/apache/flink/pull/3502 I wondered when will this PR be merged? @DmytroShkvyra --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3502: [FLINK-4565] Support for SQL IN operator
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3502 Hi @DmytroShkvyra, I'm sorry for the long time without response on this PR. We're currently in "testing & bugfix mode" for the 1.3 release and I'll be gone for two weeks in a few days. I'm sorry, but I won't have much time to look at this PR until I return. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3502: [FLINK-4565] Support for SQL IN operator
Github user DmytroShkvyra commented on the issue: https://github.com/apache/flink/pull/3502 Hi @fhueske could you review this PR. It also related to support of SQL standarts --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3502: [FLINK-4565] Support for SQL IN operator
Github user DmytroShkvyra commented on the issue: https://github.com/apache/flink/pull/3502 Hi @twalthr at last all tests are green! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3502: [FLINK-4565] Support for SQL IN operator
Github user DmytroShkvyra commented on the issue: https://github.com/apache/flink/pull/3502 @twalthr I have tried run `SubQueryRemoveRule` (register it in `FlinkRulesSets`) and so on but it have not called from Flink. I have looked thru Calcite docs and they said that calcite rules called accordingly signature of their constructors. So we should register it in `FlinkRulesSets.scala`. But scala has unpleasant thing - erasure. And I suspect it is root cause of it. P.S. Sometime I'm going crazy about travis build timeouts :-( --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3502: [FLINK-4565] Support for SQL IN operator
Github user rtudoran commented on the issue: https://github.com/apache/flink/pull/3502 I have opened an architecture design about how these can be implemented FLINK-6077 - https://issues.apache.org/jira/browse/FLINK-6077?filter=-2 You can take a look at this as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3502: [FLINK-4565] Support for SQL IN operator
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/3502 Hi @DmytroShkvyra, as I mentioned earlier, the first thing we should fix in this PR is using more of Calcite capabilities. Calcite provides a `SubQueryRemoveRule` and according to the Javadoc this is exaclty what we need in order to properly support the IN for non-literals. ``` Transform that converts IN, EXISTS and scalar sub-queries into joins. ``` But I'm fine with focusing on literals first, if you like. In general, creating objects in streaming applications is always very expensive as they have to be garbage collected which affects latency and throughput. BigDecimal should be avoided at all times and only be used if it is really necessary. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3502: [FLINK-4565] Support for SQL IN operator
Github user DmytroShkvyra commented on the issue: https://github.com/apache/flink/pull/3502 > --- T E S T S --- Running org.apache.flink.api.scala.ScalaShellITCase Running org.apache.flink.api.scala.ScalaShellLocalStartupITCase Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 19.179 sec - in org.apache.flink.api.scala.ScalaShellLocalStartupITCase The job exceeded the maximum time limit for jobs, and has been terminated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
