[GitHub] flink issue #4003: [FLINK-6075] - Support Limit/Top(Sort) for Stream SQL

2017-07-05 Thread rtudoran
Github user rtudoran commented on the issue:

https://github.com/apache/flink/pull/4003
  
I have updated these contributions against the master branch and based on 
the latest modifications after the merge of the basis for orderby. I opened a 
new PR for this #4263.
I will close this one as it is not relevant anymore


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink issue #4003: [FLINK-6075] - Support Limit/Top(Sort) for Stream SQL

2017-07-03 Thread rtudoran
Github user rtudoran commented on the issue:

https://github.com/apache/flink/pull/4003
  
@fhueske I will re-factor these contributions (hopefully by the end of the 
week) based on the things that are already merged from order by. I will ping 
you soon 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink issue #4003: [FLINK-6075] - Support Limit/Top(Sort) for Stream SQL

2017-05-29 Thread rtudoran
Github user rtudoran commented on the issue:

https://github.com/apache/flink/pull/4003
  
@fhueske - Fine for me! I just wanted to finish this as well :)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink issue #4003: [FLINK-6075] - Support Limit/Top(Sort) for Stream SQL

2017-05-28 Thread fhueske
Github user fhueske commented on the issue:

https://github.com/apache/flink/pull/4003
  
Thanks for the update @rtudoran. 
I'm traveling for another week before I return in the office. I hope I'll 
find time to have a look at #3889 in the next days. I think we should try to 
get that in first and later rebase this PR once the first part has been merged.

Thank you, Fabian


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink issue #4003: [FLINK-6075] - Support Limit/Top(Sort) for Stream SQL

2017-05-28 Thread rtudoran
Github user rtudoran commented on the issue:

https://github.com/apache/flink/pull/4003
  
@shijinkui @hongyuhong @stefanobortoli 
I add you to the issue to track the progress


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink issue #4003: [FLINK-6075] - Support Limit/Top(Sort) for Stream SQL

2017-05-28 Thread rtudoran
Github user rtudoran commented on the issue:

https://github.com/apache/flink/pull/4003
  
@fhueske 
I have implemented meanwhile also the support for offset and fetch for both 
rowtime and proctime. This PR includes all the modifications and reviews you 
made for #3889.
You can either go ahead first with that one and chekc if the basis is ok 
and merge that - and then we move to this one, or we can consider this 
directly. This PR will close the JIRA 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---