[GitHub] flink issue #4153: [FLINK-6927] [cep] Support pattern group in CEP
Github user dianfu commented on the issue: https://github.com/apache/flink/pull/4153 @dawidwys Thanks a lot for the review. Updated the doc. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #4153: [FLINK-6927] [cep] Support pattern group in CEP
Github user dawidwys commented on the issue: https://github.com/apache/flink/pull/4153 @dianfu Thanks for the update. The code looks really nice right now. The only thing that is missing for this PR, are the docs. Could you please add a section about the group patterns? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #4153: [FLINK-6927] [cep] Support pattern group in CEP
Github user dianfu commented on the issue: https://github.com/apache/flink/pull/4153 @dawidwys thanks a lot for your comments. Have updated the PR and it should have addressed all the comments. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #4153: [FLINK-6927] [cep] Support pattern group in CEP
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4153 Hi @dianfu and @dawidwys . I think that we should stick to the current API as: 1) a new API will raise serious backwards compatibility concerns, 2) people have already started using the current API and 3) there are two parallel efforts going on (SQL/ CEP standalone) and we should not block one on the other. If we agree on this, then this PR is ready for review @dawidwys . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #4153: [FLINK-6927] [cep] Support pattern group in CEP
Github user dawidwys commented on the issue: https://github.com/apache/flink/pull/4153 @dianfu sorry I have not reviewed it yet, but I do think this feature would benefit from reworking of the Pattern API I propose in [FLINK-3414](https://issues.apache.org/jira/browse/FLINK-3414). Instead of checking for head/tail of group pattern and caching them, we could more or less use current code for plain sequence creation that could return begin/end states. Then the code for joining groups would be much easier, cause it would operate on already translated sequences. Also the new API would make [FLINK-4641]](https://issues.apache.org/jira/browse/FLINK-4641) much easier I think. As it would require API rework I would really like to hear @kl0u opinion. If we agree though not to change the API I will go straight to reviewing this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #4153: [FLINK-6927] [cep] Support pattern group in CEP
Github user dianfu commented on the issue: https://github.com/apache/flink/pull/4153 rebase the code and @dawidwys @kl0u could you help to take a look at this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #4153: [FLINK-6927] [cep] Support pattern group in CEP
Github user dianfu commented on the issue: https://github.com/apache/flink/pull/4153 @dawidwys @kl0u It will be great if you could take a look at this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
