[GitHub] flink issue #4349: [FLINK-7127] [runtime] Remove unnecessary null check or a...
Github user mylog00 commented on the issue: https://github.com/apache/flink/pull/4349 Thanks for the advice. I will not repeat this mistake again in the future :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #4349: [FLINK-7127] [runtime] Remove unnecessary null check or a...
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4349 One other thing: For commit messages, they should convey the exact final fix. So, instead of "Remove unnecessary null check OR add null check", it should simply state how it is fixed. I'll adjust it appropriately this time for you :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #4349: [FLINK-7127] [runtime] Remove unnecessary null check or a...
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4349 Thanks for the fix! LGTM, merging .. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #4349: [FLINK-7127] [runtime] Remove unnecessary null check or a...
Github user mylog00 commented on the issue: https://github.com/apache/flink/pull/4349 Link to passed tests build: https://travis-ci.org/mylog00/flink/builds/253949055 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
