[GitHub] flink issue #4533: [FLINK-7416][network] Implement Netty receiver outgoing p...
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/4533 Sure, I close it. ---
[GitHub] flink issue #4533: [FLINK-7416][network] Implement Netty receiver outgoing p...
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4533 merged in 1752fdb339df4e4d0a5063b24c460abdc0a44264 @zhijiangW can you close this PR? ---
[GitHub] flink issue #4533: [FLINK-7416][network] Implement Netty receiver outgoing p...
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/4533 @NicoK , thanks for the patch you provided offline, and I submit the new commit for your changes. :) ---
[GitHub] flink issue #4533: [FLINK-7416][network] Implement Netty receiver outgoing p...
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4533 oh, you were faster... ---
[GitHub] flink issue #4533: [FLINK-7416][network] Implement Netty receiver outgoing p...
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4533 ok, I fiddled with my remarks a bit and you are right for the problems of reducing the visibility, which is partly caused by the `CreditBasedClientHandler` not replacing `PartitionRequestClientHandler` yet. I'll send you my suggestions offline (as I can't attach them here) and they should fix all my last remarks. ---
[GitHub] flink issue #4533: [FLINK-7416][network] Implement Netty receiver outgoing p...
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/4533 @NicoK @pnowojski , I have updated the codes for above comments. ---
[GitHub] flink issue #4533: [FLINK-7416][network] Implement Netty receiver outgoing p...
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/4533 @NicoK , I have updates the modifications addressed your comments. :) ---
[GitHub] flink issue #4533: [FLINK-7416][network] Implement Netty receiver outgoing p...
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/4533 @NicoK , I updated the codes for the above comments. ---
[GitHub] flink issue #4533: [FLINK-7416][network] Implement Netty receiver outgoing p...
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/4533 @pnowojski , the updates are already finished. ---
[GitHub] flink issue #4533: [FLINK-7416][network] Implement Netty receiver outgoing p...
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/4533 @pnowojski , I have submitted the modifications which include the loop issue and UTs. ---
[GitHub] flink issue #4533: [FLINK-7416][network] Implement Netty receiver outgoing p...
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/4533 @pnowojski , I have submitted the modifications. ---
[GitHub] flink issue #4533: [FLINK-7416][network] Implement Netty receiver outgoing p...
Github user pnowojski commented on the issue: https://github.com/apache/flink/pull/4533 Ok thanks for the clarification. Previously I didn't understand how this is supposed to work, but after saying this: > Actually `CreditBasedClientHandler` would replace the current `PartitionRequestClientHandler` it all makes sense :) ---
[GitHub] flink issue #4533: [FLINK-7416][network] Implement Netty receiver outgoing p...
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/4533 `notifyCreditAvailable` would be called by three logics in `RemoteInputChannel`. They are `RemoteInputChannel#recycle`, `RemoteInputChannel#notifyBufferAvailable` and `RemoteInputChannel#onSenderBacklog` which are covered in previous PRs. All the previous PRs are already merged into master except [FLINK-7406](https://github.com/apache/flink/pull/4509). In details, when the channel's credit is increased from zero, it will try to notify the producer of it. For example: 1. Recycle the exclusive buffers to increase credit after record processed. 2. The buffer pool notifies the channel of available floating buffers to increase credit 3. When receiving the backlog from producer, it may trigger to request floating buffers from buffer pool. Credit is increased when returned floating buffers from buffer pool. ---
[GitHub] flink issue #4533: [FLINK-7416][network] Implement Netty receiver outgoing p...
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/4533 @pnowojski , thanks for your reviews! I should explain the context beforehand. We present the separate `CreditBasedClientHandler` in order not to affect the current logic in master branch when partial PRs merged. Actually it would replace the current `PartitionRequestClientHandler` after all this feature codes merged. Different from previous [FLINK-7406](https://github.com/apache/flink/pull/4509) which is related with ingoing pipeline logic, and this PR is for outgoing pipeline logic. ---
